Skip to content

🚑️ Add service_principal_name support for ACLs#774

Merged
renardeinside merged 1 commit intomainfrom
chore/add-spn-to-acls
May 11, 2023
Merged

🚑️ Add service_principal_name support for ACLs#774
renardeinside merged 1 commit intomainfrom
chore/add-spn-to-acls

Conversation

@renardeinside
Copy link
Copy Markdown
Contributor

@renardeinside renardeinside commented May 11, 2023

Proposed changes

Addresses #773

Types of changes

What types of changes does your code introduce to dbx?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@renardeinside renardeinside changed the title provide fixes 🚑️ Add service_principal_name support for ACLs May 11, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2023

Codecov Report

Merging #774 (9974c37) into main (1771390) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #774   +/-   ##
=======================================
  Coverage   93.69%   93.69%           
=======================================
  Files          98       98           
  Lines        3840     3841    +1     
  Branches      483      483           
=======================================
+ Hits         3598     3599    +1     
  Misses        184      184           
  Partials       58       58           
Impacted Files Coverage Δ
dbx/__init__.py 100.00% <100.00%> (ø)
dbx/models/workflow/common/access_control.py 100.00% <100.00%> (ø)

@renardeinside renardeinside merged commit fae4812 into main May 11, 2023
@renardeinside renardeinside deleted the chore/add-spn-to-acls branch May 11, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

access_control_list validation prevents assinging service_principal_name to Workflow permissions

1 participant