Open
Conversation
Replace assert_df_equality with assertDataFrameEqual from pyspark.testing.utils. Remove chispa dependency. Closes #1105 Co-authored-by: Isaac
ghanse
added
needs-changes
Replace chispa references with pyspark.testing.utils. Part of #1105 Co-authored-by: Isaac
ghanse
added
needs-review
mwojtyczka
added
Approved to Merge
4 tasks
…atible with older Spark versions (#995) <!-- Summary of your changes that are easy to understand. Add screenshots when necessary --> * Improved Agent guidelines * Make `has_valid_schema` check compatible with older spark versions (< 4) * Fix issue with subqueries in sql `expression` check in Serverless v5 when check name is not provided (auto-derived) * Added guidelines on how to configure DQX with LDP/DLT (Lakeflow Declarative Pipelines) to enable incrementalization for Materialized Views (MVs) * Improved validation of required check function arguments * Fix CI issues <!-- DOC: Link issue with a keyword: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved. See https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> Resolves: #1053 <!-- How is this tested? Please see the checklist below and also describe any other relevant tests --> - [x] manually tested - [x] added unit tests - [x] added integration tests - [ ] added end-to-end tests - [ ] added performance tests --------- Co-authored-by: Marcin Wojtyczka <marcin.wojtyczka@databricks.com> Co-authored-by: mwojtyczka <mwojtyczka@users.noreply.github.com>
|
✅ 20/20 passed, 1 skipped, 1h32m48s total Running from acceptance #4406 |
|
✅ 176/176 passed, 1 flaky, 9h21m27s total Flaky tests:
Running from anomaly #519 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1107 +/- ##
=======================================
Coverage 55.62% 55.62%
=======================================
Files 101 101
Lines 9418 9418
=======================================
Hits 5239 5239
Misses 4179 4179
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
chispa.assert_df_equalitywithpyspark.testing.utils.assertDataFrameEqualacross all test fileschispafrompyproject.tomltest dependencies anduv.lockassert_df_equality_ignore_fingerprintswrapper intests/integration/conftest.pyto translate chispa-style kwargs (ignore_nullable,ignore_column_order,ignore_row_order) to PySpark equivalents (checkRowOrder)transformsparameter in e2e PII notebook by applying transforms before assertionchispa==0.10.1%pip installfrom e2e Databricks notebooksLinked issues
Closes #1105
Tests