-
Notifications
You must be signed in to change notification settings - Fork 6
Fixed dataset/widget name uniqueness requirement that was preventing dashboards being deployed #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dashboards being deployed
|
❌ 35/36 passed, 1 failed, 2 skipped, 55m20s total ❌ test_dashboards_creates_dashboard_with_replace_database: databricks.sdk.errors.platform.BadRequest: [INSUFFICIENT_PERMISSIONS] Insufficient privileges: (1.941s)Running from acceptance #342 |
nfx
added a commit
that referenced
this pull request
Jul 30, 2024
* Fixed dataset/widget name uniqueness requirement that was preventing dashboards being deployed ([#241](#241)). A fix has been implemented to address a uniqueness requirement issue with the dataset/widget name that was preventing dashboard deployment. A new `widget` instance is now created with a unique name, generated by appending `_widget` to the metadata ID, in the `get_layouts` method. This ensures that multiple widgets with the same ID but different content can exist in a single dashboard, thereby meeting the name uniqueness requirement. In the `save_to_folder` method, the widget name is modified by removing the `_widget` suffix before writing the textbox specification to a markdown file, maintaining consistency between the widget ID and file name. These changes are localized to the `get_layouts` and `save_to_folder` methods, and no new methods have been added. The existing functionality related to the creation, validation, and saving of dashboard layouts remains unaltered.
Merged
nfx
added a commit
that referenced
this pull request
Jul 30, 2024
* Fixed dataset/widget name uniqueness requirement that was preventing dashboards being deployed ([#241](#241)). A fix has been implemented to address a uniqueness requirement issue with the dataset/widget name that was preventing dashboard deployment. A new `widget` instance is now created with a unique name, generated by appending `_widget` to the metadata ID, in the `get_layouts` method. This ensures that multiple widgets with the same ID but different content can exist in a single dashboard, thereby meeting the name uniqueness requirement. In the `save_to_folder` method, the widget name is modified by removing the `_widget` suffix before writing the textbox specification to a markdown file, maintaining consistency between the widget ID and file name. These changes are localized to the `get_layouts` and `save_to_folder` methods, and no new methods have been added. The existing functionality related to the creation, validation, and saving of dashboard layouts remains unaltered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.