Skip to content

Fixed dataset/widget name uniqueness requirement that was preventing dashboards being deployed #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Fixed dataset/widget name uniqueness requirement that was preventing dashboards being deployed #241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/databricks/labs/lsql/dashboards.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ def validate(self) -> None:

def get_layouts(self) -> Iterable[Layout]:
"""Get the layout(s) reflecting this tile in the dashboard."""
widget = Widget(name=self.metadata.id, textbox_spec=self.content)
widget = Widget(name=f"{self.metadata.id}_widget", textbox_spec=self.content)
layout = Layout(widget=widget, position=self.position)
yield layout

Expand Down Expand Up @@ -914,7 +914,8 @@ def save_to_folder(self, dashboard: Dashboard, local_path: Path) -> Dashboard:
yaml.safe_dump(page.as_dict(), f)
for layout in page.layout:
if layout.widget.textbox_spec is not None:
(local_path / f"{layout.widget.name}.md").write_text(layout.widget.textbox_spec)
name = layout.widget.name.removesuffix("_widget")
(local_path / f"{name}.md").write_text(layout.widget.textbox_spec)
return dashboard

def create_dashboard(
Expand Down