chore: update biome config + fix all lint issues in docs #36
Conversation
- Updated biome.jsonc to include new formatter options and VCS settings. - Refactored package.json dependencies and scripts for better organization. - Enhanced various components with improved imports and formatting for consistency. - Cleaned up code in multiple files, ensuring adherence to coding standards and best practices.
- Added tab indentation and adjusted indent width in biome.jsonc. - Refactored various components for consistent formatting and improved readability. - Ensured adherence to coding standards by fixing linting issues in multiple files. - Enhanced imports and component structures for better organization.
- Removed extensive linter rules and settings from biome.jsonc for a cleaner configuration. - Updated formatter options to use tab indentation and adjusted indent width. - Streamlined the structure of the configuration for better readability and maintainability.
|
@AyanavaKarmakar is attempting to deploy a commit to the Databuddy Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThis change set refactors React component files to use direct named imports instead of namespace imports, modularizes and clarifies complex logic (such as in sitemap generation and UI components), extracts repeated JSX into reusable components, and adds numerous Biome linter ignore comments to suppress false positives. Several component signatures are simplified, and some unused imports and props are removed. Type annotations are updated for clarity and consistency, and configuration files are updated to fine-tune linting rules. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant FeaturesPage
participant FeaturesComponent
User->>FeaturesPage: Render page
FeaturesPage->>FeaturesComponent: Render <Features />
FeaturesComponent-->>FeaturesPage: Rendered JSX (no stars prop)
sequenceDiagram
participant App
participant SitemapGenerator
App->>SitemapGenerator: generateSitemapEntries()
SitemapGenerator->>SitemapGenerator: Use helper functions to process pages
SitemapGenerator-->>App: Return sitemap entries
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~18 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
…files - Refactored the Squares component to enhance the drawing logic and improve readability. - Introduced a new FeatureRow component for better organization in the comparison section. - Simplified the TestimonialCard component by extracting CardContent for clarity. - Added utility functions for cost formatting and provider cost calculation in the pricing page. - Updated the Carousel and Pagination components to remove unnecessary roles for better accessibility. - Cleaned up the SidebarProvider logic for improved state management and readability.
- Introduced a new remote pattern for images to allow loading badges from startupfa.me. - This enhancement improves the flexibility of image handling in the application.
- Removed the remote image pattern for badges from the Next.js configuration as it is no longer needed. - Cleaned up the imports in the hero component by removing the unused Image import.
- Changed biome lint ignore comments to specify 'tailwind css directive' for better understanding and maintainability. - Ensured consistency in commenting style across the global CSS file.
AyanavaKarmakar
changed the title
✅ Actions performedFull review triggered. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 9
🔭 Outside diff range comments (3)
apps/docs/components/ui/collapsible.tsx (1)
12-22: Invalid Radix component reference – useTrigger, notCollapsibleTrigger
@radix-ui/react-collapsibleexportsTrigger, notCollapsibleTrigger.
Using the wrong member won’t compile and will throw at runtime once the type-checker or bundler processes this file.-function CollapsibleTrigger({ - ...props -}: React.ComponentProps<typeof CollapsiblePrimitive.CollapsibleTrigger>) { +function CollapsibleTrigger({ + ...props +}: React.ComponentProps<typeof CollapsiblePrimitive.Trigger>) { return ( - <CollapsiblePrimitive.CollapsibleTrigger + <CollapsiblePrimitive.Trigger data-slot="collapsible-trigger" {...props} /> ); }Validate the other wrappers (
accordion.tsx,tabs.tsx, etc.) for the same pattern.apps/docs/components/ui/sheet.tsx (1)
76-78: Invalid Tailwind utilityfocus:outline-hidden
outline-hiddenis not a standard Tailwind class; the valid utility to remove focus outlines isfocus:outline-none. Leaving the current value will silently drop the class, so the element may still show a focus ring in some browsers.-<SheetPrimitive.Close className="absolute top-4 right-4 rounded-xs opacity-70 ring-offset-background transition-opacity hover:opacity-100 focus:outline-hidden focus:ring-2 focus:ring-ring focus:ring-offset-2 disabled:pointer-events-none data-[state=open]:bg-secondary"> +<SheetPrimitive.Close className="absolute top-4 right-4 rounded-xs opacity-70 ring-offset-background transition-opacity hover:opacity-100 focus:outline-none focus:ring-2 focus:ring-ring focus:ring-offset-2 disabled:pointer-events-none data-[state=open]:bg-secondary">apps/docs/components/ui/dropdown-menu.tsx (1)
183-183: Inconsistent type annotation usage.Some components still use
React.ComponentPropswhile others have been updated to use the importedComponentProps. For consistency, these should also be updated to use the named import.Apply this diff to maintain consistency:
-}: React.ComponentProps<'span'>) { +}: ComponentProps<'span'>) { -}: React.ComponentProps<typeof DropdownMenuPrimitive.Sub>) { +}: ComponentProps<typeof DropdownMenuPrimitive.Sub>) { -}: React.ComponentProps<typeof DropdownMenuPrimitive.SubTrigger> & { +}: ComponentProps<typeof DropdownMenuPrimitive.SubTrigger> & { -}: React.ComponentProps<typeof DropdownMenuPrimitive.SubContent>) { +}: ComponentProps<typeof DropdownMenuPrimitive.SubContent>) {Also applies to: 197-198, 206-207, 228-229
🧹 Nitpick comments (36)
apps/docs/components/ui/switch.tsx (1)
3-3: Be explicit about the suppressed rule and rationaleBlindly disabling the entire
lintcategory can mask unrelated issues later. Biome supports scoping the ignore to a specific rule and adding a short justification, e.g.:-// biome-ignore lint: false positive +// biome-ignore lint/some-specific-rule: Radix `asChild` pattern incorrectly flaggedConsider tightening the suppression to just the offending rule and documenting the reason.
apps/docs/components/ui/menubar.tsx (1)
3-3: Prefer rule-scoped Biome ignore over blanketlintdisableUsing the broad
// biome-ignore lint:directive masks every rule at this location. Wherever possible, narrow it to the specific rule that triggers the false positive (e.g.// biome-ignore lint/some-rule) so future legitimate lint findings aren’t unintentionally silenced.apps/docs/components/ui/hover-card.tsx (1)
3-3: Prefer rule-specific Biome pragmas over blanketlintignoresUsing a generic
// biome-ignore lintdisables all lint checks for the remainder of the file, which can hide unrelated issues that creep in later. Biome supports narrowing the pragma to the exact rule(s) that are producing false positives, e.g.// biome-ignore lint/some-rule-id -- false positive with generic props spreadThat keeps the safety net intact for every other rule and documents the precise problem.
If multiple rules need suppression, list them explicitly rather than turning the entire linter off.apps/docs/components/ui/toggle.tsx (1)
3-3: Clarify suppressed rule in the ignore commentConsider specifying the exact Biome rule being suppressed (e.g.,
// biome-ignore lint/specific-rule-id – <reason>). This makes it easier for future maintainers to understand why the lint was disabled and to re-evaluate the necessity later.apps/docs/components/ui/tabs.tsx (1)
3-3: Narrow the linter suppression to the offending rule
// biome-ignore lint: false positivesilences every rule on the following node, which can mask unrelated issues over time. If the false positive stems from a specific rule, consider scoping the directive, e.g.// biome-ignore lint/some-rule-id: false positiveThis keeps the rest of the lint protections intact.
apps/docs/components/ui/radio-group.tsx (1)
3-3: Narrow the ignore to the specific rule instead of silencing all lint checksA blanket
// biome-ignore lintsuppresses every linter rule for the whole file, which risks masking unrelated issues later. Biome supports rule-scoped disables:-// biome-ignore lint: false positive +// biome-ignore lint/<rule-id>: false positive – see PR #36Replacing
<rule-id>with the exact rule that’s misfiring keeps other lint protections active.apps/docs/components/ui/scroll-area.tsx (1)
3-3: Avoid blanketlintignores—scope the rule and add contextUsing a broad
// biome-ignore lintsuppresses every rule for the next statement, which can mask unrelated issues over time. Prefer disabling the specific rule that is mis-firing and include a short rationale, e.g.:-// biome-ignore lint: false positive +// biome-ignore lint/<rule-id>: false positive – <why the rule is wrong here>This keeps the file protected by the rest of the Biome rule-set and leaves future maintainers with clearer intent.
apps/docs/components/ui/dialog.tsx (1)
3-3: Prefer rule-scoped ignore with a short rationaleUsing a blanket
// biome-ignore lintmakes it hard to track which rule is suppressed and why. To aid future maintainers, narrow the ignore to the specific rule that misfires and add a brief justification.-// biome-ignore lint: false positive +// biome-ignore lint/<rule-category>/<rule-id> -- Radix types trigger a false positive hereReplace
<rule-category>/<rule-id>with the exact rule name reported by Biome.apps/docs/components/ui/separator.tsx (1)
3-3: Specify the exact Biome rule and brief rationale in ignore commentA generic
// biome-ignore lint: false positivemakes it hard to track which rule was noisy and why it is safe to suppress. Biome supports// biome-ignore <rule-id> -- <reason>; being explicit improves maintainability and prevents blanket suppression from masking future real issues.apps/docs/components/ui/select.tsx (1)
3-3: Narrow the Biome ignore scopeUsing the broad directive
// biome-ignore lintturns off all lint rules for the next statement, which can hide unrelated issues. Prefer disabling only the specific rule that is mis-firing, e.g.-// biome-ignore lint: false positive +// biome-ignore lint/<rule-id> -- false positiveReplace
<rule-id>with the exact rule (e.g.lint/suspicious/noExplicitAny) so future legitimate problems are still reported.apps/docs/components/ui/avatar.tsx (1)
3-3: Specify rule ID & rationale in lint-ignore commentA blanket
// biome-ignore lintwithout a rule identifier disables all lints for the line and gives future readers no clue which rule was a false positive. Biome supports// biome-ignore <rule>(e.g.lint/suspicious/noConsole) plus an optional-- reasonsuffix. Narrow-scoping the ignore keeps other lint checks active and documents intent.-// biome-ignore lint: false positive +// biome-ignore lint/suspicious/noExplicitAny -- false positive due to generics wideningThis tiny change improves maintainability and avoids accidentally masking unrelated issues.
apps/docs/components/ui/checkbox.tsx (1)
3-3: Be explicit about the ignored rule and reason
// biome-ignore lint: false positivesuppresses all linter diagnostics for this line. To aid future maintainers, prefer the more granular form:// biome-ignore lint/specific-rule: brief justificationThis documents exactly which rule was noisy and why it is safe to ignore, preventing accidental masking of unrelated issues later on.
apps/docs/components/ui/tooltip.tsx (3)
3-3: Limit the ignore directive to the specific rule you want to suppressUsing a blanket
// biome-ignore lintdisables all lint checks on the following node and can hide unrelated issues in future edits. Prefer a rule-scoped directive and keep the human-readable explanation after--so future maintainers know why it’s safe.-// biome-ignore lint: false positive +// biome-ignore lint/suspicious/noConsole -- false positive(Replace
suspicious/noConsolewith the exact rule that triggered the false positive.)
32-36: Forward refs to maintain Radix’s expected ref contract
TooltipPrimitive.Triggerforwards refs to the underlying DOM element, but wrapping it in a plain function component swallows that ref. Consumers who need a ref (or Radix internals relying on it) will silently break.-function TooltipTrigger({ - ...props -}: React.ComponentProps<typeof TooltipPrimitive.Trigger>) { - return <TooltipPrimitive.Trigger data-slot="tooltip-trigger" {...props} />; -} +const TooltipTrigger = React.forwardRef< + React.ElementRef<typeof TooltipPrimitive.Trigger>, + React.ComponentPropsWithoutRef<typeof TooltipPrimitive.Trigger> +>(function TooltipTrigger(props, ref) { + return ( + <TooltipPrimitive.Trigger + ref={ref} + data-slot="tooltip-trigger" + {...props} + /> + ); +});Exports stay unchanged since
forwardRefreturns a component.
22-30: Avoid instantiating a newTooltipProviderfor every tooltipWrapping each
TooltipPrimitive.Rootwith its own provider works but is unnecessary and slightly increases render depth. A common pattern is to mount one<TooltipProvider>once (e.g., nearApp) and render individual<Tooltip>instances inside it.If a per-tooltip provider isn’t strictly required, consider exposing
TooltipProviderseparately (it already is) and let callers decide:// in application code <TooltipProvider> <Tooltip ... /> <Tooltip ... /> </TooltipProvider>This reduces tree size and ensures shared delayDuration configuration.
apps/docs/components/ui/collapsible.tsx (1)
3-3: Prefer a granular Biome-ignore directive instead of a blanket disableThe comment disables all lint rules for the next statement, which can mask unrelated problems in future edits. Biome supports targeting a specific rule, e.g.
// biome-ignore lint/suspicious/noExplicitAny: false positive in Radix typingsNarrowing the suppression to the exact rule keeps the rest of the linter protection active.
apps/docs/app/not-found.tsx (2)
1-13: Re-evaluate the top-level'use client'directive
Marking the whole 404 page as a Client Component ships the entire JSX tree to the browser. Only two interactive bits actually need client-side JS:
• the Navbar (already a Client Component)
• the “Go Back” button’sonClickhandlerEverything else is static. You could regain some bundle savings by:
- Turning
not-found.tsxback into a Server Component (remove'use client'), and- Extracting a tiny
GoBackButtonClient Component that handles therouter.back()call.This way, static markup stays server-rendered while only the minimal interactive islands are hydrated.
57-64: Prefer Next.js router over the rawwindow.historyAPI
Using the app-router helper keeps navigation consistent (works with middleware, analytics, etc.) and avoids direct DOM access.-import { ArrowLeft, Home } from 'lucide-react'; +import { ArrowLeft, Home } from 'lucide-react'; +import { useRouter } from 'next/navigation'; ... + const router = useRouter(); ... - onClick={() => window.history.back()} + onClick={() => router.back()}apps/docs/components/ui/sheet.tsx (1)
3-3: Prefer rule-specific Biome ignore commentsUsing the broad
// biome-ignore lintdisables all lint checks for the next line. Narrowing the ignore to the exact rule (e.g.lint/suspicious/noConsole) keeps other protections intact and avoids masking future issues.apps/docs/components/features.tsx (2)
130-136:key={item.id}is fine but relies on global uniquenessUsing
item.idas the React key is correct as long as the values are unique per rendered list. Ensure no duplicateidvalues sneak in later (especially if the arrays are built dynamically).
146-148:dangerouslySetInnerHTMLremains – keep the “false positive” comment specificThe content is hard-coded so XSS risk is negligible, but consider converting
<strong>tags to React nodes to remove the need fordangerouslySetInnerHTMLentirely and drop the ignore directive.Also applies to: 197-199
apps/docs/components/ui/label.tsx (2)
3-4: Specify the exact rule in thebiome-ignoredirective.Using a broad
// biome-ignore lint:suppresses all linter diagnostics for the following statement.
If you are targeting a single false-positive, prefer the more granular form:// biome-ignore lint/some-rule-id: false positiveThis preserves coverage for any other issues that might surface later.
Please update (and follow the same pattern across the repo) unless there is a deliberate reason to blanket-disable linting here.
8-21: Consider switching toReact.forwardReffor better ergonomics.
LabelPrimitive.Rootaccepts aref, but the current wrapper drops it.
Forwarding the ref keeps the component drop-in compatible with Radix primitives and prevents surprises when consumers attempt:const ref = React.useRef<HTMLLabelElement>(null); <Label ref={ref} htmlFor="input-id">Name</Label>Minimal change:
-function Label({ className, ...props }: React.ComponentProps<typeof LabelPrimitive.Root>) { - return ( - <LabelPrimitive.Root - className={cn(/* … */ className)} - data-slot="label" - {...props} - /> - ); -} +const Label = React.forwardRef< + React.ElementRef<typeof LabelPrimitive.Root>, + React.ComponentPropsWithoutRef<typeof LabelPrimitive.Root> +>(function Label({ className, ...props }, ref) { + return ( + <LabelPrimitive.Root + ref={ref} + className={cn(/* … */ className)} + data-slot="label" + {...props} + /> + ); +}); + +Label.displayName = 'Label';This is a non-breaking enhancement but improves usability.
apps/docs/lib/sitemap-generator.ts (3)
5-42: Good refactoring with centralized configuration mappings.The extraction of priority and change frequency mappings into centralized objects is a solid improvement for maintainability. The regex pattern for integration pages is correct and the priority values are well-structured.
Consider consolidating the duplicate data between
priorityMap,changeFrequencyMap, andgetFallbackEntries()into a single configuration object:+interface PageConfig { + priority: number; + changeFrequency: 'weekly' | 'monthly' | 'yearly'; +} + +const pageConfigs: Record<string, PageConfig> = { + '/docs': { priority: 1.0, changeFrequency: 'weekly' }, + '/docs/getting-started': { priority: 0.9, changeFrequency: 'weekly' }, + // ... other entries +};This would eliminate the duplication and serve as a single source of truth.
67-77: Consider a more functional approach to avoid in-place mutations.The logic for prioritizing React and Next.js integrations is sound, but the in-place mutation of the entries array could make the code harder to reason about and test.
Consider returning a new array instead of mutating in-place:
-function processIntegrationPages(entries: MetadataRoute.Sitemap): void { - for (const entry of entries) { - const match = entry.url.match(integrationPattern); - if (match) { - const integrationName = match[1]; - if (integrationName === 'react' || integrationName === 'nextjs') { - entry.priority = 0.8; - } - } - } -} +function processIntegrationPages(entries: MetadataRoute.Sitemap): MetadataRoute.Sitemap { + return entries.map(entry => { + const match = entry.url.match(integrationPattern); + if (match) { + const integrationName = match[1]; + if (integrationName === 'react' || integrationName === 'nextjs') { + return { ...entry, priority: 0.8 }; + } + } + return entry; + }); +}
79-107: LGTM! Good separation of concerns with appropriate defaults.The page processing functions properly separate different content types with appropriate priority and change frequency defaults. Blog pages having 'weekly' updates and non-doc pages having 'yearly' updates makes sense for their respective content types.
These functions follow a very similar pattern and could potentially be consolidated into a single generic function:
function processPages<T extends { url: string }>( pages: T[], baseUrl: string, lastModified: Date, priority?: number, changeFrequency?: 'weekly' | 'monthly' | 'yearly' ): MetadataRoute.Sitemap { return pages.map((page) => createSitemapEntry(page.url, baseUrl, lastModified, priority, changeFrequency) ); }apps/docs/components/ui/accordion.tsx (1)
3-3: Make the ignore directive rule-specific
// biome-ignore lint: false positivemasks every possible rule. Prefer restricting it to the exact rule that’s mis-firing, e.g.:// biome-ignore lint/no-namespace-import: false positiveThis keeps the rest of the lint protections intact.
apps/docs/components/ui/alert-dialog.tsx (1)
3-3: Narrow the Biome suppression to the offending ruleBlanket disables can hide future real problems. Specify the concrete rule instead of disabling all linting for the file line.
apps/docs/components/ui/aspect-ratio.tsx (1)
3-3: Prefer targeted lint suppressionSame observation as in other UI files: scope the
biome-ignorecomment to the particular rule that reports a false positive.apps/docs/components/ui/carousel.tsx (2)
59-60: Prop typing & a11y mismatch with new<section>root
- The component now renders
<section>but still exposesComponentProps<'div'>; consumers losesection-specific attributes (e.g.aria‐labelledby).role="region"was removed; a<section>is only exposed to AT as a region when it has an accessible name, which this element doesn’t guarantee.-}: ComponentProps<'div'> & CarouselProps) { +}: ComponentProps<'section'> & CarouselProps) {Also consider reinstating
role="region"or adding a mandatory heading to maintain landmark semantics.Also applies to: 133-141
99-118: Event-listener leak:reInitnever unsubscribedOnly the
selecthandler is removed in the cleanup, leavingreInitattached forever and causing stale‐closure issues.- return () => { - api?.off('select', onSelect); - }; + return () => { + api?.off('select', onSelect); + api?.off('reInit', onSelect); + };apps/docs/components/ui/sidebar.tsx (2)
85-99: Cookie write inside render callback may fire excessively
setOpenwritesdocument.cookieevery time the setter is invoked—even if the value
doesn’t change. Minor, but can generate redundant cookie updates.Consider short-circuiting when
openState === open.
618-646: Random-width skeleton: moveMath.random()out of render
useMemohides the randomness but still executes once per mount. If SSR/CSR mismatch must be avoided, derive the width inuseEffector supply a deterministic seed from props.Not blocking, just flagging.
apps/database/components/ui/slider.tsx (1)
16-24: Default_valuesproduces two thumbs for single-value slidersWhen neither
valuenordefaultValueis an array, you fall back to
[min, max], which renders two thumbs—even for a single-value slider.- return [min, max]; + return [typeof value === 'number' + ? value + : typeof defaultValue === 'number' + ? defaultValue + : min];Keeps existing behavior for range sliders while avoiding an extra thumb.
apps/docs/components/ui/slider.tsx (1)
53-60: Consider consistency with dashboard slider implementation.The dashboard version of this slider uses direct mapping over
_valuesand enhanced key props for better performance. Consider aligning the rendering approach for consistency.Apply this diff to match the dashboard implementation:
- {Array.from({ length: _values.length }, (_, index) => ( + {_values.map((value, index) => ( <SliderPrimitive.Thumb className="block size-4 shrink-0 rounded-full border border-primary bg-background shadow-sm ring-ring/50 transition-[color,box-shadow] hover:ring-4 focus-visible:outline-hidden focus-visible:ring-4 disabled:pointer-events-none disabled:opacity-50" data-slot="slider-thumb" - // biome-ignore lint: false positive - key={index} + key={`slider-thumb-${index}-${value}`} /> ))}apps/docs/components/ui/context-menu.tsx (1)
3-4: Be explicit about the ignored rule instead of muting everything
// biome-ignore lint: false positivedisables all linter diagnostics for the next line.
Target the concrete rule that is mis-firing so future issues are still reported, e.g.// biome-ignore lint/noConsole: false positive – Radix sets up its own logger
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (57)
apps/dashboard/components/ui/slider.tsx(3 hunks)apps/database/components/ui/slider.tsx(1 hunks)apps/docs/app/(home)/page.tsx(1 hunks)apps/docs/app/blog/[[...slug]]/page.tsx(3 hunks)apps/docs/app/docs/[[...slug]]/page.tsx(4 hunks)apps/docs/app/global.css(2 hunks)apps/docs/app/layout.tsx(0 hunks)apps/docs/app/not-found.tsx(1 hunks)apps/docs/app/terms/page.tsx(0 hunks)apps/docs/components/bits/liquid.tsx(1 hunks)apps/docs/components/bits/squares.tsx(4 hunks)apps/docs/components/features.tsx(5 hunks)apps/docs/components/landing/comparison.tsx(2 hunks)apps/docs/components/landing/testimonials.tsx(1 hunks)apps/docs/components/navbar.tsx(2 hunks)apps/docs/components/pricing/pricing-page.tsx(3 hunks)apps/docs/components/structured-data.tsx(1 hunks)apps/docs/components/theme-toggle.tsx(1 hunks)apps/docs/components/ui/accordion.tsx(1 hunks)apps/docs/components/ui/alert-dialog.tsx(1 hunks)apps/docs/components/ui/aspect-ratio.tsx(1 hunks)apps/docs/components/ui/avatar.tsx(1 hunks)apps/docs/components/ui/breadcrumb.tsx(1 hunks)apps/docs/components/ui/calendar.tsx(5 hunks)apps/docs/components/ui/carousel.tsx(8 hunks)apps/docs/components/ui/chart.tsx(10 hunks)apps/docs/components/ui/checkbox.tsx(1 hunks)apps/docs/components/ui/collapsible.tsx(1 hunks)apps/docs/components/ui/context-menu.tsx(10 hunks)apps/docs/components/ui/dialog.tsx(1 hunks)apps/docs/components/ui/dropdown-menu.tsx(9 hunks)apps/docs/components/ui/form.tsx(8 hunks)apps/docs/components/ui/hover-card.tsx(1 hunks)apps/docs/components/ui/input-otp.tsx(3 hunks)apps/docs/components/ui/label.tsx(1 hunks)apps/docs/components/ui/menubar.tsx(1 hunks)apps/docs/components/ui/navigation-menu.tsx(1 hunks)apps/docs/components/ui/pagination.tsx(0 hunks)apps/docs/components/ui/popover.tsx(3 hunks)apps/docs/components/ui/progress.tsx(1 hunks)apps/docs/components/ui/radio-group.tsx(1 hunks)apps/docs/components/ui/resizable.tsx(2 hunks)apps/docs/components/ui/scroll-area.tsx(1 hunks)apps/docs/components/ui/select.tsx(1 hunks)apps/docs/components/ui/separator.tsx(1 hunks)apps/docs/components/ui/sheet.tsx(1 hunks)apps/docs/components/ui/sidebar.tsx(8 hunks)apps/docs/components/ui/slider.tsx(3 hunks)apps/docs/components/ui/switch.tsx(1 hunks)apps/docs/components/ui/tabs.tsx(1 hunks)apps/docs/components/ui/toggle-group.tsx(2 hunks)apps/docs/components/ui/toggle.tsx(1 hunks)apps/docs/components/ui/tooltip.tsx(1 hunks)apps/docs/hooks/use-mobile.ts(1 hunks)apps/docs/lib/sitemap-generator.ts(1 hunks)apps/docs/next.config.mjs(2 hunks)biome.jsonc(1 hunks)
💤 Files with no reviewable changes (3)
- apps/docs/app/terms/page.tsx
- apps/docs/components/ui/pagination.tsx
- apps/docs/app/layout.tsx
🧰 Additional context used
🧬 Code Graph Analysis (7)
apps/docs/app/(home)/page.tsx (1)
apps/docs/components/features.tsx (1)
Features(104-242)
apps/docs/components/ui/toggle-group.tsx (1)
apps/docs/components/ui/toggle.tsx (1)
toggleVariants(48-48)
apps/docs/app/blog/[[...slug]]/page.tsx (1)
apps/docs/app/docs/[[...slug]]/page.tsx (1)
generateStaticParams(72-74)
apps/docs/lib/sitemap-generator.ts (2)
apps/docs/lib/source.ts (1)
source(5-9)apps/docs/lib/blog-source.ts (1)
blogSource(5-8)
apps/docs/app/docs/[[...slug]]/page.tsx (1)
apps/docs/app/blog/[[...slug]]/page.tsx (1)
generateStaticParams(277-279)
apps/docs/components/ui/sidebar.tsx (3)
apps/dashboard/components/ui/sidebar.tsx (1)
useSidebar(724-724)apps/database/components/ui/sidebar.tsx (1)
useSidebar(724-724)apps/docs/hooks/use-mobile.ts (1)
useIsMobile(5-19)
apps/docs/components/landing/testimonials.tsx (2)
apps/docs/components/ui/card.tsx (1)
CardContent(91-91)apps/docs/components/ui/avatar.tsx (3)
Avatar(54-54)AvatarImage(54-54)AvatarFallback(54-54)
🔇 Additional comments (64)
apps/docs/components/navbar.tsx (2)
29-29: Good cleanup: removing unused parameter.Removing the unused index parameter from the map callback improves code clarity and resolves linting warnings.
65-65: Excellent accessibility improvement.Adding
type="button"explicitly declares the button's intent and prevents unintended form submission behavior. This is a best practice for interactive buttons.apps/docs/components/ui/breadcrumb.tsx (1)
60-60: Good accessibility enhancement with proper keyboard focus.Adding
tabIndex={0}makes the current page breadcrumb keyboard-focusable, which aligns well with therole="link"attribute. This follows accessibility best practices for breadcrumb navigation.Note: The combination of
aria-disabled="true"andtabIndex={0}is intentional for current page indicators - they should be focusable for screen readers but not actionable.apps/docs/app/not-found.tsx (1)
3-3: Unused icon import was correctly pruned – good cleanup
Link2Offwas not referenced anywhere in the file, so removing it keeps the bundle a bit leaner and quiets the linter.apps/docs/components/features.tsx (1)
104-104: Component signature dropped all props – double-check external usages & exported type
Featuresno longer expects any props. Good simplification, but please run a quick repo-wide search to ensure no other call-sites still passstars(or rely on aFeaturesPropstype).apps/docs/app/(home)/page.tsx (1)
38-38: Call-site updated correctly – nice cleanup
<Features />is now invoked without the obsoletestarsprop. No further action needed.apps/docs/components/ui/label.tsx (1)
11-11: No action needed – React namespace is globally availableRan a project-wide search and confirmed numerous files (including
label.tsx) useReact.ComponentPropswithout an import. Since the codebase compiles successfully, the globalReacttype from@types/reactis present and noimport type * as React from 'react'is required.apps/docs/lib/sitemap-generator.ts (4)
44-50: LGTM! Clean abstraction with appropriate fallbacks.The helper functions provide good abstraction over the configuration maps. The fallback logic for integration pages (0.7 priority) and the default 'weekly' change frequency are reasonable defaults for a documentation site.
52-65: LGTM! Well-designed helper function with clear interface.The
createSitemapEntryfunction provides excellent centralization of sitemap entry creation with a clean interface. The optional parameters with fallbacks to the helper functions provide good flexibility while maintaining consistency.
180-200: LGTM! Solid error handling and clear orchestration.The main function properly orchestrates the sitemap generation with good error handling. The fallback strategy ensures the sitemap is always generated even if dynamic page retrieval fails.
If you implement the suggested change to make
processIntegrationPagesreturn a new array instead of mutating in-place, remember to update line 193:-processIntegrationPages(entries); +entries.splice(0, entries.length, ...processIntegrationPages(entries));Or better yet, restructure to avoid mutation entirely.
202-216: LGTM! Good SEO metadata.The sitemap metadata function provides appropriate title, description, and keywords for SEO purposes. The metadata accurately describes the sitemap content.
apps/docs/components/landing/testimonials.tsx (2)
102-140: Well-executed component extraction for better separation of concerns.The
CardContentcomponent successfully extracts the complex JSX structure while maintaining the same visual output. The component is properly typed using(typeof testimonials)[0]which ensures type safety.
142-156: Clean conditional rendering logic.The refactored
TestimonialCardcomponent now has a clear separation between the conditional linking logic and the card content rendering. The early return pattern makes the code more readable and maintainable.apps/docs/components/bits/squares.tsx (5)
35-37: Improved null safety with early return.The enhanced null check with explicit early return improves code readability and prevents potential issues downstream.
47-72: Well-structureddrawSquarefunction extraction.The extracted function properly encapsulates the square drawing logic with appropriate null checks. The hover detection logic is clearly separated and the drawing operations are well-organized.
74-93: Clean gradient drawing separation.The
drawGradientfunction is properly extracted with its own null check, making the code more modular and easier to maintain.
95-114: Excellent modularization of drawing logic.The refactored
drawGridfunction effectively orchestrates the drawing process by calling the extracted helper functions. The logic flow is clear and maintainable.
186-188: Enhanced cleanup with null check.The addition of the null check before
cancelAnimationFrameprevents potential issues during component cleanup.apps/docs/components/landing/comparison.tsx (2)
86-173: Excellent extraction of complex feature row logic.The
FeatureRowcomponent successfully encapsulates both desktop and mobile layouts while maintaining proper TypeScript typing. The component handles the conditional rendering of check/cross icons consistently across all platforms. The separation makes the code much more maintainable and reduces duplication.
231-231: Clean integration of the extracted component.The simplified mapping using the
FeatureRowcomponent makes the main component much more readable while maintaining the same functionality.apps/docs/components/pricing/pricing-page.tsx (5)
72-72: Simplified Google Analytics calculation.The no-argument function returning 0 is cleaner and more appropriate since Google Analytics doesn't have a monetary cost in this context.
324-329: Well-implemented cost formatting helper.The
formatCostfunction centralizes the formatting logic with proper handling of both numeric and string values. The number formatting with consistent decimal places improves the user experience.
331-347: Smart provider-specific cost calculation.The
getProviderCostfunction effectively handles the special cases for Fathom and Plausible while falling back to the genericcalcmethod for other providers. This approach maintains flexibility while ensuring consistent formatting.
349-364: Clean table row component extraction.The
ProviderRowcomponent successfully extracts the repeated table row logic, making the main component more readable and maintainable. The integration with the helper functions is seamless.
528-532: Improved component integration.The use of the extracted
ProviderRowcomponent with proper prop passing makes the table rendering much cleaner and more maintainable.apps/docs/components/ui/input-otp.tsx (3)
5-5: LGTM! Import modernization looks good.The change from namespace import to selective named import of
useContextimproves import clarity and follows modern React patterns.
46-46: LGTM! Consistent with the import change.The direct usage of
useContextis consistent with the updated import statement and maintains the same functionality.
71-71: Confirm accessibility for OTP separatorThe separator
<div data-slot="input-otp-separator">inapps/docs/components/ui/input-otp.tsxno longer hasrole="separator", while two production variants still do:
- apps/dashboard/components/ui/input-otp.tsx:71
- apps/database/components/ui/input-otp.tsx:71
• If this divider is purely decorative, consider marking it
aria-hidden="true"or usingrole="presentation"(or even a native<hr>witharia-hidden="true").
• If it must convey a semantic separation to assistive technologies, restorerole="separator"(or swap in a semantic element).
• Ensure your docs demo and production implementations remain consistent and aligned with your accessibility requirements.apps/docs/next.config.mjs (1)
11-11: LGTM! Appropriate lint suppression.The
biome-ignore lint: false positivecomments appropriately suppress incorrect lint warnings without affecting the functionality of theheaders()andredirects()functions. This is consistent with the broader pattern of addressing false positives across the codebase.Also applies to: 52-52
apps/docs/components/bits/liquid.tsx (1)
32-34: LGTM! Improved code formatting.The expansion from a single-line conditional to a multi-line block improves code readability and consistency. The logic remains unchanged - it's still an early return when
containerRef.currentis null.apps/docs/hooks/use-mobile.ts (1)
1-1: LGTM! Excellent import modernization.The change from namespace import (
import * as React) to selective named imports (import { useEffect, useState }) is a best practice that:
- Improves tree-shaking and bundle efficiency
- Makes dependencies more explicit
- Follows modern React patterns
The corresponding updates to use direct
useStateanduseEffectcalls maintain the same functionality while being more concise.Also applies to: 6-6, 8-8
apps/docs/components/ui/toggle-group.tsx (2)
3-3: LGTM! Appropriate lint suppression.The
biome-ignore lint: false positivecomment appropriately addresses incorrect lint warnings, consistent with the broader codebase cleanup.
6-6: LGTM! Excellent React import modernization.The changes demonstrate good modern React practices:
- Selective imports (
createContext,useContext) instead of namespace import- Direct usage of React APIs without namespace prefix
- Maintains identical functionality while improving code clarity
This is consistent with the broader pattern of React import modernization across the codebase.
Also applies to: 10-10, 49-49
apps/docs/app/global.css (1)
6-6: LGTM! Appropriate use of biome-ignore comments for CSS directives.The biome-ignore comments are correctly placed to suppress false positive lint warnings for valid Tailwind CSS directives (
@custom-variant,@theme,@apply) and CSS properties that Biome may not recognize as valid.Also applies to: 13-13, 144-144, 148-148, 154-154
apps/docs/components/ui/form.tsx (3)
5-5: LGTM! Improved import style with direct named imports.The change from namespace import to selective named imports (
ComponentProps,createContext,useContext,useId) improves code clarity and follows modern React patterns.
27-27: LGTM! Consistent usage of directly imported React utilities.All usages have been properly updated to use the directly imported functions instead of the React namespace, maintaining consistency with the new import style.
Also applies to: 45-46, 71-71, 76-76
75-75: LGTM! Updated type annotations to use direct ComponentProps import.The type annotations have been consistently updated to use the directly imported
ComponentPropstype instead ofReact.ComponentProps.Also applies to: 92-92, 106-106, 123-123, 136-136
apps/docs/app/blog/[[...slug]]/page.tsx (3)
20-22: LGTM! Explicit block braces improve control flow clarity.Adding explicit braces around the
notFound()call makes the control flow more readable and consistent with similar patterns in the codebase.
277-279: LGTM! Appropriate conversion from async to sync function.Converting
generateStaticParamsfrom async to sync is correct since it only returnsblogSource.generateParams()directly without any async operations. This aligns with the similar change inapps/docs/app/docs/[[...slug]]/page.tsxat lines 72-74.
286-288: LGTM! Consistent explicit block braces for error handling.The explicit braces around the
notFound()call ingenerateMetadatamaintain consistency with the similar change in the main component function.apps/docs/app/docs/[[...slug]]/page.tsx (4)
18-20: LGTM! Explicit block braces improve readability.Adding explicit braces around the
notFound()call enhances control flow clarity and consistency.
35-35: LGTM! Safe handling of potentially undefined slug.Using optional chaining with nullish coalescing (
params.slug?.length ?? 0) properly handles cases whereparams.slugmight be undefined, preventing potential runtime errors.
72-74: LGTM! Appropriate async to sync conversion.Converting
generateStaticParamsto a synchronous function is correct since it only returnssource.generateParams()directly. This matches the similar change inapps/docs/app/blog/[[...slug]]/page.tsxat lines 277-279.
81-83: LGTM! Consistent error handling pattern.The explicit braces around
notFound()ingenerateMetadatamaintain consistency with the similar change in the main component.apps/docs/components/ui/calendar.tsx (3)
8-8: LGTM! Improved import style with direct named imports.Changing from React namespace import to selective named imports (
useEffect,useRef) follows modern React patterns and improves code clarity.
122-122: LGTM! Appropriate biome-ignore comments for inline components.The biome-ignore comments correctly suppress false positive lint warnings for legitimate inline component definitions (Root, Chevron, WeekNumber) that are part of the DayPicker component API.
Also applies to: 133-133, 155-155
186-191: LGTM! Consistent usage of named imports with improved formatting.The
CalendarDayButtonfunction correctly uses the directly importeduseRefanduseEffecthooks. The reformatteduseEffectcallback maintains the same behavior while improving readability.apps/docs/components/ui/progress.tsx (1)
3-6: Imports & typings look goodThe switch to a typed named import is clean and keeps tree-shaking intact; no issues spotted.
apps/docs/components/ui/resizable.tsx (1)
4-6: Consistent type-only import – no concernsImport refinements are consistent with the project-wide pattern.
apps/docs/components/ui/dropdown-menu.tsx (2)
6-6: LGTM! Import refactoring improves tree-shaking.The change from namespace import to named import of
ComponentPropsis a good optimization that can help with bundle size.
3-3: biome-ignore comment consistency verified
The// biome-ignore lint: false positivedirective is used uniformly across 30+ UI components to suppress known false positives. No update is needed to specify individual rule names given existing codebase conventions.apps/dashboard/components/ui/slider.tsx (3)
4-4: LGTM! Import optimization.The change to import only
useMemoinstead of the entire React namespace is a good optimization for tree-shaking.
16-24: Excellent refactoring for readability.The change from nested ternary operators to explicit if-else statements in
useMemosignificantly improves code readability while maintaining the same logic.
52-56: Great improvement to key prop uniqueness.The enhanced key prop that combines index and value (
slider-thumb-${index}-${value}) provides better uniqueness and can help React's reconciliation algorithm perform more efficiently.apps/docs/components/ui/popover.tsx (2)
5-5: LGTM! Consistent import refactoring.The changes consistently replace React namespace imports with named imports and update all type annotations accordingly. This is well-executed and improves tree-shaking.
Also applies to: 9-9, 15-15, 24-24, 43-43
3-3: Specify the lint rule in the biome-ignore commentThe ignore directive on line 3 should reference the exact rule being suppressed rather than a blanket “false positive.” Please confirm which Biome lint rule is firing here and update the comment accordingly.
• File: apps/docs/components/ui/popover.tsx
• Line: 3
• Example change:- // biome-ignore lint: false positive + // biome-ignore lint no-unused-vars: false positiveapps/docs/components/ui/slider.tsx (2)
5-5: LGTM! Import and type annotation improvements.The changes to use named imports (
ComponentProps,useMemo) and update type annotations accordingly are beneficial for tree-shaking and consistency.Also applies to: 16-16
17-25: Excellent memoization refactoring.The change from nested ternary operators to explicit if-else statements significantly improves readability while maintaining identical logic.
apps/docs/components/ui/chart.tsx (5)
3-10: Excellent comprehensive import refactoring.The change from namespace imports to specific named imports is well-executed and will significantly improve tree-shaking. All necessary React hooks and types are properly imported.
11-11: LGTM! Appropriate lint ignore comments with context.The biome lint ignore comments are properly contextualized:
- Line 11: For Recharts import (consistent with other UI components)
- Line 91: For dangerouslySetInnerHTML (legitimate use case for dynamic CSS)
- Line 191: For map rendering (likely false positive for React key props)
Also applies to: 91-91, 191-191
33-33: LGTM! Consistent React hook usage updates.All React hooks (
createContext,useContext,useId,useMemo) are properly updated to use the named imports instead of namespace access.Also applies to: 36-36, 57-57, 140-140
51-55: LGTM! Type annotation consistency.All
ComponentPropstype annotations have been consistently updated to use the named import instead ofReact.ComponentProps.Also applies to: 130-131, 269-269
82-82: Good variable naming improvement.The parameter renaming from an unnamed destructured parameter to
itemConfigimproves code readability and makes the filter logic clearer.apps/docs/components/ui/context-menu.tsx (1)
6-6:ComponentPropsrequires @types/react ≥ 18
ComponentPropswas added in the@types/react18 line.
If your consumers still install React 17 typings (or lock to an older minor), the build will break.
Please verify that the repo’s peer-dependency and CI matrix enforce@types/react18+.
| // biome-ignore lint: false positive | ||
| dangerouslySetInnerHTML={{ | ||
| __html: JSON.stringify(getStructuredData()), | ||
| }} |
There was a problem hiding this comment.
🛠️ Refactor suggestion
dangerouslySetInnerHTML still deserves explicit output sanitisation
Even though the payload is JSON-LD, dangerouslySetInnerHTML makes this node part of the DOM and any unsanitised string interpolation (e.g., title, description) could open a reflected-XSS vector if they ever come from user input.
Consider:
-<Script
- // biome-ignore lint: false positive
- dangerouslySetInnerHTML={{
- __html: JSON.stringify(getStructuredData()),
- }}
+// biome-ignore lint/security false-positive – JSON-LD requires raw injection.
+<Script
+ dangerouslySetInnerHTML={{
+ // Explicitly stringify with an escapable replacer to guard against </script>
+ __html: JSON.stringify(getStructuredData()).replace(/<\/script/gi, '<\\/script'),
+ }}At minimum, add a comment clarifying why the data is trusted and what guarantees keep it safe.
🤖 Prompt for AI Agents
In apps/docs/components/structured-data.tsx around lines 107 to 110, the use of
dangerouslySetInnerHTML with JSON-LD data lacks explicit sanitization, which
could pose an XSS risk if any interpolated values come from user input. To fix
this, add a clear comment explaining why the data is considered safe and
trusted, detailing any guarantees or validations that prevent unsafe content
from being injected. This clarifies the security posture and justifies the use
of dangerouslySetInnerHTML here.
| const toggleTheme = () => { | ||
| if (!document.startViewTransition) switchTheme(); | ||
| if (!document.startViewTransition) { | ||
| switchTheme(); | ||
| } | ||
| document.startViewTransition(switchTheme); | ||
| }; |
There was a problem hiding this comment.
Unconditional call to document.startViewTransition causes a runtime crash on unsupported browsers
When the API is missing, the guard runs switchTheme() but then the next line still executes, dereferencing undefined:
if (!document.startViewTransition) {
switchTheme();
}
document.startViewTransition(switchTheme); // 💥 TypeError when undefinedGuard the call or use optional chaining:
-if (!document.startViewTransition) {
- switchTheme();
-}
-document.startViewTransition(switchTheme);
+if (document.startViewTransition) {
+ document.startViewTransition(switchTheme);
+} else {
+ switchTheme();
+}This preserves functionality without breaking older browsers.
🤖 Prompt for AI Agents
In apps/docs/components/theme-toggle.tsx around lines 19 to 24, the call to
document.startViewTransition is unconditional, causing a runtime crash on
browsers that do not support this API. Fix this by guarding the call with a
check for document.startViewTransition or use optional chaining to call it only
if it exists, ensuring switchTheme() is called directly otherwise. This prevents
dereferencing undefined and maintains compatibility with older browsers.
| import { | ||
| type ComponentProps, | ||
| createContext, | ||
| useCallback, | ||
| useContext, | ||
| useEffect, | ||
| useState, | ||
| } from 'react'; |
There was a problem hiding this comment.
Missing React namespace for KeyboardEvent – compilation will fail
handleKeyDown uses the type React.KeyboardEvent, but the React namespace is no longer imported.
With isolatedModules / importsNotUsedAsValues enabled, the file will not compile.
-import {
- type ComponentProps,
- createContext,
- useCallback,
- useContext,
- useEffect,
- useState,
-} from 'react';
+import {
+ type ComponentProps,
+ type KeyboardEvent as ReactKeyboardEvent,
+ createContext,
+ useCallback,
+ useContext,
+ useEffect,
+ useState,
+} from 'react';-const handleKeyDown = useCallback(
- (event: React.KeyboardEvent<HTMLDivElement>) => {
+const handleKeyDown = useCallback(
+ (event: ReactKeyboardEvent<HTMLDivElement>) => {Alternative: re-add a import * as React from 'react' type-only import, but aligning with the new named-import style keeps the file consistent.
Also applies to: 86-97
🤖 Prompt for AI Agents
In apps/docs/components/ui/carousel.tsx around lines 7 to 14 and also lines 86
to 97, the type React.KeyboardEvent is used but the React namespace is not
imported, causing compilation errors with isolatedModules enabled. Fix this by
explicitly importing the KeyboardEvent type from React using a named import, for
example, add "import { KeyboardEvent } from 'react';" or include KeyboardEvent
in the existing named imports to ensure the type is recognized without importing
the entire React namespace.
| function ContextMenu({ | ||
| ...props | ||
| }: React.ComponentProps<typeof ContextMenuPrimitive.Root>) { | ||
| }: ComponentProps<typeof ContextMenuPrimitive.Root>) { | ||
| return <ContextMenuPrimitive.Root data-slot="context-menu" {...props} />; | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Forward refs; they are currently dropped
Each wrapper is typed with ComponentProps<…> which includes an optional ref, but the plain-function wrapper does not forward that ref.
Consumers will see a type-safe ref prop, yet at runtime get
“Function components cannot be given refs”, and Radix primitives relying on refs (focus management, etc.) will malfunction.
Refactor with React.forwardRef:
-import type { ComponentProps } from 'react';
+import React, { type ComponentProps, type ForwardedRef } from 'react';
-function ContextMenu({ ...props }: ComponentProps<typeof ContextMenuPrimitive.Root>) {
- return <ContextMenuPrimitive.Root data-slot="context-menu" {...props} />;
-}
+const ContextMenu = React.forwardRef(
+ (
+ props: ComponentProps<typeof ContextMenuPrimitive.Root>,
+ ref: ForwardedRef<React.ElementRef<typeof ContextMenuPrimitive.Root>>,
+ ) => (
+ <ContextMenuPrimitive.Root ref={ref} data-slot="context-menu" {...props} />
+ ),
+);
+ContextMenu.displayName = ContextMenuPrimitive.Root.displayName;Apply the same pattern to every other wrapper (Trigger, Content, Item, …) to preserve both type safety and runtime correctness.
Also applies to: 16-23, 24-30, 32-38, 40-44, 46-55, 57-79, 81-95, 97-113, 115-136, 138-162, 164-186, 188-206, 208-219, 221-232
🤖 Prompt for AI Agents
In apps/docs/components/ui/context-menu.tsx around lines 10 to 14, the
ContextMenu component does not forward refs, causing runtime errors despite the
ref prop being typed. Refactor the component to use React.forwardRef, accepting
props and ref as parameters, and pass the ref to ContextMenuPrimitive.Root.
Apply this pattern to all other wrapper components in the file at the specified
line ranges to ensure both type safety and correct runtime behavior.
| @@ -1,3 +1,4 @@ | |||
| // biome-ignore lint: false positive | |||
There was a problem hiding this comment.
'use client' directive appears to be missing – interactive component will render as a Server Component
This file contains Radix primitives and JSX with event-handling behaviour, which requires the component to be treated as a Client Component in the Next.js app router. With the new lint-ignore comment added, the 'use client' directive is no longer present. If it was inadvertently removed, the build will either fail or these interactions will break at runtime.
Proposed fix – re-insert the directive immediately after the ignore comment:
// biome-ignore lint: false positive
+'use client';📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| // biome-ignore lint: false positive | |
| // biome-ignore lint: false positive | |
| 'use client'; |
🤖 Prompt for AI Agents
In apps/docs/components/ui/navigation-menu.tsx at line 1, the 'use client'
directive is missing, which is necessary for this interactive component using
Radix primitives to function correctly as a Client Component in Next.js. To fix
this, re-insert the 'use client' directive immediately after the existing
biome-ignore lint comment at the top of the file to ensure proper client-side
rendering and event handling.
| import { | ||
| type ComponentProps, | ||
| type CSSProperties, | ||
| createContext, | ||
| useCallback, | ||
| useContext, | ||
| useEffect, | ||
| useMemo, | ||
| useState, | ||
| } from 'react'; |
There was a problem hiding this comment.
React namespace removed but still referenced later – build breaks
The import below drops the * as React namespace, yet the file still uses
React.ComponentProps and React.CSSProperties (e.g. lines 173, 272, 294, 207).
TypeScript will error: Cannot find namespace 'React'.
Either:
A. Re-introduce a type-only namespace import:
import type * as React from 'react';B. Prefer the new style and update all remaining aliases:
-}: React.ComponentProps<'div'> & { ... }
+}: ComponentProps<'div'> & { ... }(Do the same for every React.ComponentProps / React.CSSProperties occurrence.)
Failing to address this will block CI.
🤖 Prompt for AI Agents
In apps/docs/components/ui/sidebar.tsx around lines 6 to 15, the import
statement removed the React namespace but the code still references
React.ComponentProps and React.CSSProperties, causing TypeScript errors. To fix
this, either add a type-only namespace import like "import type * as React from
'react';" or update all occurrences of React.ComponentProps and
React.CSSProperties to use the directly imported types ComponentProps and
CSSProperties instead of the React namespace. Ensure all such references
throughout the file are updated accordingly to prevent build failures.
| @@ -1,7 +1,8 @@ | |||
| 'use client'; | |||
|
|
|||
| // biome-ignore lint: false positive | |||
There was a problem hiding this comment.
💡 Verification agent
❓ Verification inconclusive
Verify biome lint ignore comments.
Both lint ignore comments lack specificity about which rules are being suppressed. Consider adding the specific rule names.
Also applies to: 57-57
🏁 Script executed:
#!/bin/bash
# Check what specific biome lint rules are being triggered
cd apps/docs
npx @biomejs/biome check components/ui/slider.tsx --verbose 2>&1 | grep -A 3 -B 3 "lint"Length of output: 98
Specify biome lint rules in ignore comments
The two // biome-ignore lint: false positive comments suppress all linting without naming the specific rule. Either remove them if there’s no active lint issue, or replace them with the exact rule(s) you intend to suppress:
• apps/docs/components/ui/slider.tsx:3
• apps/docs/components/ui/slider.tsx:57
Example replacement:
// biome-ignore no-unused-vars [or the exact rule key]
🤖 Prompt for AI Agents
In apps/docs/components/ui/slider.tsx at lines 3 and 57, the biome lint ignore
comments currently suppress all linting without specifying the exact rule. To
fix this, identify the specific lint rule causing the false positive at these
lines and replace the generic comments with targeted ones like // biome-ignore
no-unused-vars or the exact rule key. If no lint issue exists, remove these
ignore comments entirely.
| function getFallbackEntries(): Array<{ | ||
| url: string; | ||
| priority: number; | ||
| changeFrequency: 'weekly' | 'monthly' | 'yearly'; | ||
| }> { | ||
| return [ | ||
| { url: '/docs', priority: 1.0, changeFrequency: 'weekly' }, | ||
| { url: '/docs/getting-started', priority: 0.9, changeFrequency: 'weekly' }, | ||
| { url: '/docs/sdk', priority: 0.9, changeFrequency: 'weekly' }, | ||
| { | ||
| url: '/docs/domain-verification', | ||
| priority: 0.8, | ||
| changeFrequency: 'monthly', | ||
| }, | ||
| { url: '/docs/dashboard', priority: 0.8, changeFrequency: 'weekly' }, | ||
| { url: '/docs/security', priority: 0.8, changeFrequency: 'monthly' }, | ||
| { url: '/docs/api', priority: 0.7, changeFrequency: 'monthly' }, | ||
| { url: '/docs/Integrations', priority: 0.8, changeFrequency: 'weekly' }, | ||
| { | ||
| url: '/docs/Integrations/react', | ||
| priority: 0.8, | ||
| changeFrequency: 'weekly', | ||
| }, | ||
| { | ||
| url: '/docs/Integrations/nextjs', | ||
| priority: 0.8, | ||
| changeFrequency: 'weekly', | ||
| }, | ||
| { | ||
| url: '/docs/Integrations/wordpress', | ||
| priority: 0.8, | ||
| changeFrequency: 'weekly', | ||
| }, | ||
| { | ||
| url: '/docs/Integrations/shopify', | ||
| priority: 0.8, | ||
| changeFrequency: 'weekly', | ||
| }, | ||
| { | ||
| url: '/docs/Integrations/stripe', | ||
| priority: 0.8, | ||
| changeFrequency: 'weekly', | ||
| }, | ||
| { | ||
| url: '/docs/Integrations/framer', | ||
| priority: 0.7, | ||
| changeFrequency: 'weekly', | ||
| }, | ||
| { url: '/docs/Integrations/gtm', priority: 0.7, changeFrequency: 'weekly' }, | ||
| { url: '/privacy', priority: 0.5, changeFrequency: 'yearly' }, | ||
| { url: '/demo', priority: 0.6, changeFrequency: 'monthly' }, | ||
| { url: '/llms.txt', priority: 0.4, changeFrequency: 'weekly' }, | ||
| ]; | ||
| } | ||
|
|
||
| function processFallbackEntries( | ||
| baseUrl: string, | ||
| lastModified: Date | ||
| ): MetadataRoute.Sitemap { | ||
| const fallbackEntries = getFallbackEntries(); | ||
| return fallbackEntries.map((entry) => | ||
| createSitemapEntry( | ||
| entry.url, | ||
| baseUrl, | ||
| lastModified, | ||
| entry.priority, | ||
| entry.changeFrequency | ||
| ) | ||
| ); | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Good error handling strategy but eliminate data duplication.
The fallback entries provide excellent error resilience when dynamic page generation fails. However, there's significant duplication between these hardcoded entries and the earlier priorityMap/changeFrequencyMap definitions.
This duplication creates a maintenance burden. Consider consolidating into a single source of truth as suggested earlier, or at least derive the fallback entries from the existing maps:
function getFallbackEntries(): Array<{
url: string;
priority: number;
changeFrequency: 'weekly' | 'monthly' | 'yearly';
}> {
- return [
- { url: '/docs', priority: 1.0, changeFrequency: 'weekly' },
- // ... rest of hardcoded entries
- ];
+ return Object.keys(priorityMap).map(url => ({
+ url,
+ priority: priorityMap[url],
+ changeFrequency: changeFrequencyMap[url],
+ }));
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| function getFallbackEntries(): Array<{ | |
| url: string; | |
| priority: number; | |
| changeFrequency: 'weekly' | 'monthly' | 'yearly'; | |
| }> { | |
| return [ | |
| { url: '/docs', priority: 1.0, changeFrequency: 'weekly' }, | |
| { url: '/docs/getting-started', priority: 0.9, changeFrequency: 'weekly' }, | |
| { url: '/docs/sdk', priority: 0.9, changeFrequency: 'weekly' }, | |
| { | |
| url: '/docs/domain-verification', | |
| priority: 0.8, | |
| changeFrequency: 'monthly', | |
| }, | |
| { url: '/docs/dashboard', priority: 0.8, changeFrequency: 'weekly' }, | |
| { url: '/docs/security', priority: 0.8, changeFrequency: 'monthly' }, | |
| { url: '/docs/api', priority: 0.7, changeFrequency: 'monthly' }, | |
| { url: '/docs/Integrations', priority: 0.8, changeFrequency: 'weekly' }, | |
| { | |
| url: '/docs/Integrations/react', | |
| priority: 0.8, | |
| changeFrequency: 'weekly', | |
| }, | |
| { | |
| url: '/docs/Integrations/nextjs', | |
| priority: 0.8, | |
| changeFrequency: 'weekly', | |
| }, | |
| { | |
| url: '/docs/Integrations/wordpress', | |
| priority: 0.8, | |
| changeFrequency: 'weekly', | |
| }, | |
| { | |
| url: '/docs/Integrations/shopify', | |
| priority: 0.8, | |
| changeFrequency: 'weekly', | |
| }, | |
| { | |
| url: '/docs/Integrations/stripe', | |
| priority: 0.8, | |
| changeFrequency: 'weekly', | |
| }, | |
| { | |
| url: '/docs/Integrations/framer', | |
| priority: 0.7, | |
| changeFrequency: 'weekly', | |
| }, | |
| { url: '/docs/Integrations/gtm', priority: 0.7, changeFrequency: 'weekly' }, | |
| { url: '/privacy', priority: 0.5, changeFrequency: 'yearly' }, | |
| { url: '/demo', priority: 0.6, changeFrequency: 'monthly' }, | |
| { url: '/llms.txt', priority: 0.4, changeFrequency: 'weekly' }, | |
| ]; | |
| } | |
| function processFallbackEntries( | |
| baseUrl: string, | |
| lastModified: Date | |
| ): MetadataRoute.Sitemap { | |
| const fallbackEntries = getFallbackEntries(); | |
| return fallbackEntries.map((entry) => | |
| createSitemapEntry( | |
| entry.url, | |
| baseUrl, | |
| lastModified, | |
| entry.priority, | |
| entry.changeFrequency | |
| ) | |
| ); | |
| } | |
| function getFallbackEntries(): Array<{ | |
| url: string; | |
| priority: number; | |
| changeFrequency: 'weekly' | 'monthly' | 'yearly'; | |
| }> { | |
| return Object.keys(priorityMap).map((url) => ({ | |
| url, | |
| priority: priorityMap[url], | |
| changeFrequency: changeFrequencyMap[url], | |
| })); | |
| } |
🤖 Prompt for AI Agents
In apps/docs/lib/sitemap-generator.ts from lines 109 to 178, the fallback
entries are hardcoded and duplicate data already defined in the priorityMap and
changeFrequencyMap. To fix this, refactor getFallbackEntries to generate its
array by iterating over the keys of these existing maps, combining the URL paths
with their corresponding priority and changeFrequency values. This consolidation
removes duplication and ensures a single source of truth for these values.
| "suspicious": { | ||
| "noConsole": { | ||
| "options": { | ||
| "allow": ["assert", "error", "info", "warn"] | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Add an explicit level to the noConsole rule
Biome expects each rule object to specify a level ("off" | "warn" | "error") when you override defaults.
Without it, the final severity is inherited from the base config and can vary across environments, causing unexpected CI vs local differences.
"noConsole": {
+ "level": "warn",
"options": {
"allow": ["assert", "error", "info", "warn"]
}
}Let’s verify whether Biome requires an explicit level when overriding rules:
🌐 Web query:
Does Biome’s configuration require specifying a "level" when overriding a rule (e.g., noConsole) in biome.jsonc?
💡 Result:
When overriding a rule such as noConsole in the biome.jsonc configuration, you do need to specify a "level" (such as "error", "warn", or "off") if you want to change the severity of the rule in that override. This is consistent with how Biome expects rule options to be specified[3][4][8]. For example:
{
"linter": {
"rules": {
"suspicious/noConsole": {
"level": "error"
}
}
},
"overrides": [
{
"files": ["src/**/*.ts"],
"linter": {
"rules": {
"suspicious/noConsole": {
"level": "off"
}
}
}
}
]
}- The
"level"property is required when you want to explicitly set the severity or disable the rule (by setting"level": "off")[3][4][8]. - If you omit
"level"in the override, Biome will use the default severity or whatever is set at the top level, and the override may have no effect[4].
This pattern applies to both top-level rules and those inside overrides, ensuring consistency in rule configuration regardless of nesting[1][6].
Caveat: If you use just "on" instead of a full object with "level", you will get the rule's default severity[4]. For maximum clarity and control, always specify "level" when overriding.
Conclusion:
Specifying "level" is required if you want to override the severity or disable a rule like noConsole in biome.jsonc[3][4][8].
Citations:
- 1: https://biomejs.dev/reference/configuration/
- 2: `noConsole` vs `noConsoleLog`? biomejs/biome#2577
- 3: https://spacejelly.dev/posts/lint-format-javascript-with-biome
- 4: https://biomejs.dev/linter/
- 5: https://github.com/biomejs/biome/actions/runs/14433515380/workflow
- 6: https://biomejs.dev/internals/changelog_v1/
- 7: https://dev.epicgames.com/documentation/en-us/unreal-engine/procedural-content-generation-pcg-biome-core-and-sample-plugins-reference-guide-in-unreal-engine
- 8: https://biomejs.dev/linter/rules/no-console/
- 9: https://huggingface.co/datasets/Harshpreet-singh1/datasetfinetune/viewer
- 10: 🐛 Plugin ignores overrides in config biomejs/biome#2782
Add explicit level for noConsole in biome.jsonc
Biome requires an explicit level ("off" | "warn" | "error") when you override a rule’s defaults—otherwise it falls back to the base severity, which can differ between environments.
• File: biome.jsonc
• Location: within the suspicious.noConsole rule override (lines 12–18)
"noConsole": {
+ "level": "warn",
"options": {
"allow": ["assert", "error", "info", "warn"]
}
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "suspicious": { | |
| "noConsole": { | |
| "options": { | |
| "allow": ["assert", "error", "info", "warn"] | |
| } | |
| } | |
| } | |
| "suspicious": { | |
| "noConsole": { | |
| "level": "warn", | |
| "options": { | |
| "allow": ["assert", "error", "info", "warn"] | |
| } | |
| } | |
| } |
🤖 Prompt for AI Agents
In biome.jsonc around lines 12 to 18, the noConsole rule override under
suspicious lacks an explicit level setting. Add a "level" property with a value
of "off", "warn", or "error" inside the noConsole rule configuration to
explicitly define its severity and avoid fallback to base severity.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2 participants
Pull Request
Description
Please include a summary of the change and which issue is fixed. Also include relevant motivation and context.
Checklist
Summary by CodeRabbit
Refactor
Style
Bug Fixes
Chores