01-starting-with-data: organizing statistics in a Python table#280
01-starting-with-data: organizing statistics in a Python table#280ErinBecker wants to merge 4 commits intodatacarpentry:gh-pagesfrom gustavothomas17:gh-pages
Conversation
…Frame" The name of the section starts with "Calculating Statistics" but there were actually no statistics in the section. I added a general command with the function `.describe()` and added a challenge exercise at the end of this section related to it.
Updating section "Calculating Statistics…"
maxim-belkin
left a comment
maxim-belkin
left a comment
There was a problem hiding this comment.
Thanks @ErinBecker and @gustavothomas17. Please see my comments.
| > species are in the data? | ||
| > | ||
| > 2. What is the difference between `len(site_names)` and `surveys_df['site_id'].nunique()`? | ||
| {: .challenge} |
There was a problem hiding this comment.
Why do you delete this line?
| Pandas' `describe` function will only return summary values for columns | ||
| containing numeric data (note that for the columns `species_id` and `sex` | ||
| nothing was returned). Further exploring our data set, we might want | ||
| to know how many animals were collected in each plot, or how many of each. |
There was a problem hiding this comment.
This whole new section partially repeats the text that follows.
Please either remove the duplicate text here or in the paragraphs that follows.
Also, please use the following syntax for code blocks
~~~
python code
~~~
{: .language-python}
There was a problem hiding this comment.
I cloned the repository to my PC, made the changes you requested and pushed it back @maxim-belkin, I hope to have done it correctly, if not please let me know where I did wrong and I will fix it.
There was a problem hiding this comment.
@gustavothomas17 apologies for the delay...
You used your gh-pages branch which complicates things a little bit. I will close this PR, but please submit a new one with your suggested changes using a different branch. Here is what you should do:
git clone https://github.com/datacarpentry/python-ecology-lesson new-directory
cd new-directory
git branch my-changes
git checkout my-changes
## implement your changes
git add -u
git commit
git push --force https://github.com/gustavothomas17/python-ecology-lesson gh-pages:gh-pages
git push https://github.com/gustavothomas17/python-ecology-lesson
and then submit this PR again.
I will add a few comments to your PR - please take them into account when submitting a new request.
There was a problem hiding this comment.
Thank you very much for your time @maxim-belkin, I hope to have followed your instructions properly this time.
maxim-belkin
changed the title
maxim-belkin
left a comment
maxim-belkin
left a comment
There was a problem hiding this comment.
Please see my comments.
I am closing this PR, but please submit a new one following the steps I described.
| @@ -1,3 +1,4 @@ | |||
|
|
|||
There was a problem hiding this comment.
don't add this empty line
|
|
||
| > ## Challenge - Statistics | ||
| > | ||
| > 1. What type of summary statistics is given by `surveys_df['sex'].describe()`? |
There was a problem hiding this comment.
again, you are not removing the exercise that was originally here (line 385 and below). If you are proposing to replace the existing exercise, you should delete it.
|
|
||
| We can calculate basic statistics for all records in a single column using the | ||
| syntax below: | ||
| We often want to calculate the summary statistics grouped by subsets or |
There was a problem hiding this comment.
the original text is not ideal either but... say something like:
we calculate statistics and display its summary...
| ``` | ||
|
|
||
| We can also extract one specific metric if we wish: | ||
| We can also extract specific metrics if we wish: |
There was a problem hiding this comment.
quantities of interest to us
Rename CoC file to align with GitHub's Community Profile expectation
4 participants
Submitted on behalf of @gustavothomas17.