03-index-slice-subset.md: add key points#322
03-index-slice-subset.md: add key points#322wrightaprilm merged 4 commits intodatacarpentry:gh-pagesfrom raynamharris:patch-2
Conversation
Two of the key points I took almost directly from the text. For the third, I tried to think of a bigger picture key point. Maybe these are useful.
|
Thanks for this! Happy to merge if it looks good to you, @maxim-belkin. |
|
I've submitted a few comments. Let me know if you do or do not see them |
maxim-belkin
added
status:in progress
|
And I added a couple suggestions. If they look good to you, Rayna, you can accept them and leave comment. Otherwise, feel free to suggest other wordings. |
|
I added a few comments and commits. let me know what you think |
maxim-belkin
changed the title
Co-Authored-By: raynamharris <raynamharris@users.noreply.github.com>
|
I think we're all resolved. If you're happy, I'm happy, @maxim-belkin. |
|
Besides (really minor) #322 (comment), this PR looks great! Great job both of you! https://youtu.be/69sa-jYk444?t=2 |
|
Ah, yes, the comment - I didn't realize that my suggestion became inapplicable when a previous line was edited. I made a new suggestion containing the language we agreed on (with the condition-based data selection). Let me know if its not visible, @raynamharris. Once that's sewn up, I'll merge. |
Co-Authored-By: raynamharris <raynamharris@users.noreply.github.com>
|
No worries. Thanks to both of you for all the discussion. I hope these updates are useful for learners and trainers :) |
|
Awesome work, @raynamharris & @maxim-belkin! |
03-index-slice-subset.md: add key points
3 participants
Two of the key points I took almost directly from the text. For the third, I tried to think of a bigger picture key point. Maybe these are useful.