03-index-slice-subset.md: improve wording#340
Merged
wrightaprilm merged 2 commits intodatacarpentry:gh-pagesfrom Nov 27, 2018
Merged
03-index-slice-subset.md: improve wording#340wrightaprilm merged 2 commits intodatacarpentry:gh-pagesfrom
wrightaprilm merged 2 commits intodatacarpentry:gh-pagesfrom
Conversation
Contributor
|
Thanks, @welozano! good catch! We can merge this as is. However, I'd like to suggest that we spend a bit more time and rewrite this paragraph a bit as it's not super well written. My suggestion (feel free to improve):
@wrightaprilm, please chime in. :) |
maxim-belkin
approved these changes
Nov 24, 2018
Contributor
|
I like your replacement text, Maxim. If you're willing to add it in, @welozano, we would very much appreciate it! |
wrightaprilm
approved these changes
Nov 24, 2018
Contributor
Author
|
Hi, the suggestion looks pretty good. I just added as @maxim-belkin suggested. |
Contributor
|
Great, thanks @welozano! |
idwaker
pushed a commit
to pywaker/python-ecology-lesson
that referenced
this pull request
Feb 5, 2019
added workshop calendar
zkamvar
pushed a commit
that referenced
this pull request
May 8, 2023
03-index-slice-subset.md: improve wording
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sentence refers to x > 5, I think there is an extra "not"
Wil