Skip to content

05-merging-data.md: use proper file name#343

Merged
maxim-belkin merged 1 commit intodatacarpentry:gh-pagesfrom
NPalopoli:patch-12
Nov 25, 2018
Merged

05-merging-data.md: use proper file name#343
maxim-belkin merged 1 commit intodatacarpentry:gh-pagesfrom
NPalopoli:patch-12

Conversation

@NPalopoli
Copy link
Copy Markdown
Contributor

Please delete the text below before submitting your contribution.

@maxim-belkin
Copy link
Copy Markdown
Contributor

I believe the filename is correct. Please clarify why you think it is not.

@maxim-belkin maxim-belkin added the status:need more info More information needed label Nov 24, 2018
@maxim-belkin maxim-belkin self-assigned this Nov 24, 2018
@maxim-belkin maxim-belkin changed the title correct mention of data file 05-merging-data.md: correct mention of data file Nov 24, 2018
@wrightaprilm
Copy link
Copy Markdown
Contributor

I actually like this. As-is in the lesson, we say a plots CSV file. But not that it's actually called plots.csv. I'd feel good about merging this, since it's more explicit.

@maxim-belkin
Copy link
Copy Markdown
Contributor

maxim-belkin commented Nov 24, 2018

Ooops, I apologize -- for some reason I read the PR incorrectly and got an impression that it was doing the opposite change (changing plots.csv to plot CSV). My apologies!

@maxim-belkin maxim-belkin added type:enhancement Propose enhancement to the lesson and removed status:need more info More information needed labels Nov 24, 2018
@maxim-belkin maxim-belkin changed the title 05-merging-data.md: correct mention of data file 05-merging-data.md: use proper file name Nov 25, 2018
@maxim-belkin maxim-belkin merged commit 372d2b0 into datacarpentry:gh-pages Nov 25, 2018
@maxim-belkin
Copy link
Copy Markdown
Contributor

Thank you, @NPalopoli!

zkamvar pushed a commit that referenced this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:enhancement Propose enhancement to the lesson

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants