added examples to the first two episodes of python ecology class from…#408
Closed
ezgirmak wants to merge 1 commit intodatacarpentry:gh-pagesfrom
Closed
added examples to the first two episodes of python ecology class from…#408ezgirmak wants to merge 1 commit intodatacarpentry:gh-pagesfrom
ezgirmak wants to merge 1 commit intodatacarpentry:gh-pagesfrom
Conversation
… the instructor notes
Contributor
|
Thank you, Ezgi! To speed up the review/discussion process, could you please split your pull request into smaller ones (solution-per-PR)? I linked a quick guide on how to do that but please let me know if you experience any difficulties along the way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
As part of my instructor checkout procedure, I decided to embed examples back into the lesson materials from the instructor notes as discussed in the issue #361. I did the first two episodes and tried to follow carpentries style as much as possible. If everything looks good, I can continue to do the rest of the episodes.
Here are some issues related to the second episode.
Second challenge in grouping challenges has a further example in the instructor notes 'I want to know the last survey year, median foot-length and mean weight for each plot/sex combination' Should I add it as an additional challenge?
The instructor notes and the example in the lesson for Calculating Statistics Challenges is not the same. In the instructor notes, the name of the variable is
plot_names, in the example it issite_names. The code to get number of unique species in the data in the instructor notes islen(pd.unique(surveys_df["species"]))and there is no column namedspecies. So I wrote it aslen(pd.unique(surveys_df["species_id"]))in the lesson solutions. I have not changed the notes but I can change them in my next commit.Thanks,
Ezgi