Missing data files in setup. Fixes #409#421
Missing data files in setup. Fixes #409#421jensentobias wants to merge 1 commit intodatacarpentry:gh-pagesfrom jensentobias:missing_data_files
Conversation
maxim-belkin
left a comment
maxim-belkin
left a comment
There was a problem hiding this comment.
Most of the changes look good to me! Thank you, @jensentobias!
| > Or download each file indvidually with the following links: | ||
| > | ||
| > For this lesson we will use the eight files listed below for data. | ||
| > These can be download by following the below links |
There was a problem hiding this comment.
Could you please rephrase it so that it is easier to read?
Something like this:
Data (files) used in this lesson are from the Portal Project Teaching Database available on Figshare. Specifically, we use the following eight data files:
- file one
- file two
- file three
...
Please download them (by clicking on the corresponding links) and move them to the same directory.
There was a problem hiding this comment.
I agree that its a little difficult to read, but aimed at being correct and inline with our discussion:
"Also, on the setup page we should change the wording to emphasize the fact that these three files are not in the zip archive nor can they be found on Figshare..."
I can rephrase, but should the change still highlight the fact that
- some files are not from Portal Project Teaching Database, and
- should it still link to the zip file?
There was a problem hiding this comment.
Feel free to use my suggestion as a base and expand it.
We can provide a zip file ourselves instead of relying on ever-changing files. In this case, we can say that our files are from [location] retrieved on [date].
|
A gentle ping, @jensentobias. Just curious if you had plans to continue working on this PR or if my last comment was a tad unclear. |
maxim-belkin
added
the
status:waiting for response
|
Thank you for your work, @jensentobias. I'm going to close this PR because the issue was addressed in #462. I hope to see another issue or a PR from you in the future! 🥇 |
2 participants
Based on our discussion on #409, this could be a solution.