Skip to content

Add a reminder about what the question mark does#438

Merged
tobyhodges merged 2 commits intogh-pagesfrom
maneesha-patch-2
Apr 25, 2023
Merged

Add a reminder about what the question mark does#438
tobyhodges merged 2 commits intogh-pagesfrom
maneesha-patch-2

Conversation

@maneesha
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@maxim-belkin maxim-belkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for so many contributions, Maneesha! Please see my comments below.

Comment thread _episodes/06-loops-and-functions.md Outdated
@maxim-belkin maxim-belkin added the status:waiting for response Waiting for Contributor to respond to maintainers' comments or update PR label Jan 28, 2020
@maneesha
Copy link
Copy Markdown
Contributor Author

Catching up on a very old issue!
I am fine with any of the options listed. I originally put in this PR because the ? notation is used in the example, and so the explanation should refer to what is in the example.

@maneesha maneesha removed the status:waiting for response Waiting for Contributor to respond to maintainers' comments or update PR label Feb 2, 2022
@tobyhodges
Copy link
Copy Markdown
Member

I'm helping the current lesson Maintainers process outstanding pull requests on this repository, in preparation for transition to the new lesson infrastructure. Thank you for contributing, @maneesha.

I agree that the lesson could be improved with an explanation of ?, given that it is used in the example code block. Of the three options @maxim-belkin listed, I would be most in favour of the second ("Expand the sentence to mention the built-in help() function + clarify that in Jupyter notebooks we can use topic? notation"), so I am going to suggest a change to the PR.

We have until the end of this month to get these changes merged, before the Workbench transition forces us to close the PR.

@tobyhodges tobyhodges added the status:waiting for response Waiting for Contributor to respond to maintainers' comments or update PR label Apr 4, 2023
@tobyhodges tobyhodges self-assigned this Apr 4, 2023
@tobyhodges tobyhodges added the type:clarification Suggest change for make lesson clearer label Apr 12, 2023
@tobyhodges tobyhodges merged commit 72f639f into gh-pages Apr 25, 2023
@tobyhodges tobyhodges deleted the maneesha-patch-2 branch April 25, 2023 12:36
zkamvar pushed a commit that referenced this pull request May 8, 2023
Add a reminder about what the question mark does
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:waiting for response Waiting for Contributor to respond to maintainers' comments or update PR type:clarification Suggest change for make lesson clearer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants