Skip to content

Wording and clarity edits#458

Merged
tobyhodges merged 3 commits intodatacarpentry:gh-pagesfrom
cassws:starting-with-data-wording
Apr 25, 2023
Merged

Wording and clarity edits#458
tobyhodges merged 3 commits intodatacarpentry:gh-pagesfrom
cassws:starting-with-data-wording

Conversation

@cassws
Copy link
Copy Markdown
Contributor

@cassws cassws commented Apr 29, 2020

Phrasing changes to increase clarity in some parts of lesson, such as:

  • Rewording "methods" as "processes" so learners don't confuse with object methods
  • Ambiguity re: CSV's and separators
  • Acknowledge dimension block at end of console output for dataframe (without .head() or print(df)
  • misc. phrasing

Note that the clarity around methods would be compatible with the edits in #452 (which I think are great!)

Thank you for considering!

Copy link
Copy Markdown
Contributor

@maxim-belkin maxim-belkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, @zoews! I have a few comments/requests but this is an excellent PR! 👍

Comment thread _episodes/02-starting-with-data.md Outdated
Comment thread _episodes/02-starting-with-data.md Outdated
Comment thread _episodes/02-starting-with-data.md Outdated
Comment thread _episodes/02-starting-with-data.md
Comment thread _episodes/02-starting-with-data.md Outdated
Comment thread _episodes/02-starting-with-data.md Outdated
Comment thread _episodes/02-starting-with-data.md Outdated
@maxim-belkin maxim-belkin self-assigned this Jun 17, 2020
@maxim-belkin maxim-belkin added the type:clarification Suggest change for make lesson clearer label Jun 17, 2020
@tobyhodges
Copy link
Copy Markdown
Member

I'm helping the current lesson Maintainers process outstanding pull requests on this repository, in preparation for transition to the new lesson infrastructure.

Thank you for contributing these changes, @zoews. I agree with @maxim-belkin's suggestions for how the changes could be improved further. If you would like to return and update this pull request to address his comments before the end of this month, I would be delighted to merge your enhancements.

When the infrastructure transition takes place in May 2023, this pull request will become invalid and will have to be closed.

@tobyhodges tobyhodges assigned tobyhodges and unassigned maxim-belkin Apr 4, 2023
Comment thread _episodes/02-starting-with-data.md Outdated
Comment thread _episodes/02-starting-with-data.md Outdated
Comment thread _episodes/02-starting-with-data.md Outdated
Comment thread _episodes/02-starting-with-data.md Outdated
Comment thread _episodes/02-starting-with-data.md Outdated
Comment thread _episodes/02-starting-with-data.md Outdated
Comment thread _episodes/02-starting-with-data.md Outdated
Comment thread _episodes/02-starting-with-data.md Outdated
Comment thread _episodes/02-starting-with-data.md Outdated
Comment thread _episodes/02-starting-with-data.md Outdated
@LilithElina
Copy link
Copy Markdown
Contributor

LilithElina commented Apr 12, 2023

I converted the changes @maxim-belkin proposed into code change suggestions, so @zoews or @tobyhodges can easily commit them if they accept them to merge this PR before May. Only for the last change (to move a sentence to below a code box) I had to create a new commit. I hope that's alright with everyone involved.

@maxim-belkin
Copy link
Copy Markdown
Contributor

Thanks you, @LilithElina! Glad this lesson is in good hands now.
Thank you, @tobyhodges, too! Happy to see that The Carpentries' infrastructure is evolving.

@tobyhodges tobyhodges merged commit 5db8e5c into datacarpentry:gh-pages Apr 25, 2023
zkamvar pushed a commit that referenced this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:clarification Suggest change for make lesson clearer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants