Hot007 issue307 update guide#460
Conversation
Rename a few sections to match lesson outline, add comments to episode 7 & 8, start contributing content to episode 9.
Add solution to Q2.
Add solutions/comments for second set of questions.
|
Hi @hot007! Thank you for the PR! I like your changes but I'm curious as to why you change some headings, e.g., "05-merging-data" to "05-merging-data-with-pandas". In this particular example, episode title is "Combining DataFrames with Pandas" and the filename is Other than that -- it looks great! thank you! |
|
Hi Maxim, |
|
Sounds good. Please update the PR
Excellent! Could you please update the PR accordingly then? I think these headings can be episode titles, file names (without .md), or "Episode X: Episode title". Using episode titles make the most sense to me but I don't mind if you keep them as they were. Thank you for your work and let me know if you need help or advice. Maxim |
Thanks for the review @maxim-belkin changes made as requested, hope I got all of them. Thanks for the {: .output} tip, I didn't know about that.
|
Okay, I've made the requested changes I hope, please let me know if I missed anything. Thanks for the feedback, I'm learning about this {: .} syntax, that's really helpful, apologies I had it wrong, the preview for me isn't parsing those bits so I couldn't see it wasn't working. |
My personal preference is to use "Ep. #: Episode Title" headings but what you did here makes perfect sense. Of course, we should keep episode file names in sync with the content, e.g. ggplot -> plotnine, etc., but these discrepancies should be addressed in separate PRs (1 file change per PR). I'm going to merge this PR as it seems to be ready. Thank you for the excellent contribution! If you'd like to work on any of the open issues -- let me know and I'll be happy to help! 🏅 |
Add content to Instructors Guide to Python Ecology lesson, particularly the final (SQL) section.
(part of instructor check-out).