Skip to content

add reminder about plotline installation#461

Merged
maxim-belkin merged 3 commits intodatacarpentry:gh-pagesfrom
naheld:naheldplotline_instal
Jun 5, 2020
Merged

add reminder about plotline installation#461
maxim-belkin merged 3 commits intodatacarpentry:gh-pagesfrom
naheld:naheldplotline_instal

Conversation

@naheld
Copy link
Copy Markdown
Contributor

@naheld naheld commented May 30, 2020

This addresses issue #426
Adds a reminder callout which links to the setup page, in case the learner has not yet installed plotnine.

Copy link
Copy Markdown
Contributor

@maxim-belkin maxim-belkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes "as-is" but to aggregate all links in one place I suggest moving link definition to the end of the document.

Comment thread _episodes/07-visualization-ggplot-python.md Outdated
@maxim-belkin
Copy link
Copy Markdown
Contributor

Thank you for the pull request, Noelle! I agree that it is useful to remind people that they need to install plotnine. My only suggestions would be to define setup-plotnine link and using that in the text.

@maxim-belkin maxim-belkin added type:enhancement Propose enhancement to the lesson status:waiting for response Waiting for Contributor to respond to maintainers' comments or update PR labels Jun 5, 2020
naheld and others added 2 commits June 5, 2020 16:06
aggregate links

Co-authored-by: Maxim Belkin <maxim.belkin@gmail.com>
@maxim-belkin maxim-belkin removed the status:waiting for response Waiting for Contributor to respond to maintainers' comments or update PR label Jun 5, 2020
@naheld
Copy link
Copy Markdown
Contributor Author

naheld commented Jun 5, 2020

Hi Maxim - thanks! I agree with you. I resolved your change and also added the plotnine link.

@maxim-belkin
Copy link
Copy Markdown
Contributor

Awesome! Thank you, @naheld! Great work!

🎉

@maxim-belkin maxim-belkin merged commit 6ea2e6c into datacarpentry:gh-pages Jun 5, 2020
maxim-belkin pushed a commit to maxim-belkin/python-ecology-lesson that referenced this pull request Jun 6, 2020
zkamvar pushed a commit that referenced this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:enhancement Propose enhancement to the lesson

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants