Skip to content

feat: major dashboard changes#158

Merged
WeryZebra-Yue merged 16 commits intomainfrom
ui-update
Jan 2, 2024
Merged

feat: major dashboard changes#158
WeryZebra-Yue merged 16 commits intomainfrom
ui-update

Conversation

@driptanil
Copy link
Copy Markdown
Contributor

@driptanil driptanil commented Dec 22, 2023

New Dashboard

datachecks-dashboard

Previous Dashboard

image

Fixes/Implements

  • Font changed: Gilroy to DMSans
  • Deleted ui/src/contexts/ApiContext.ts and ui/src/api/LocalApi.ts (no usage)
  • Added New Bootstrap Tooltip, PieChart and Card Components
  • In src/api/Api.ts changed all interfaces to types
  • Added new CSS variable for colours
  • In ui/src/types/component.type.ts added ‘metric_validation_unchecked’

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Locally Tested
  • Needs Testing From Production

Changes :

- Font changed: Gilroy to DMSans
- Deleted `ui/src/contexts/ApiContext.ts` and `ui/src/api/LocalApi.ts` (no usage)
- Added New Bootstrap Tooltip and PieChart Components
- Renamed Overview to Overall
- Created a new component called Overview
- In `src/api/Api.ts` changed all interfaces to types
- In Preview, used `React.useEffect` and `React.useState` hooks to make the pie charts responsive
- Added new CSS variable for colours
- In `ui/src/types/component.type.ts` added ‘metric_validation_unchecked’
@driptanil driptanil added ⚡️enhancement New feature or request Dashboard Metric Dashboard labels Dec 22, 2023
@WeryZebra-Yue
Copy link
Copy Markdown
Contributor

Hey @driptanil, few things I need to address here:

  1. can we squash every commit on this PR into one commit?
  2. name of this PR can be in format of
    1. fix()-...
    2. feat()-...
    3. docs()-..
      with a small case and more useful message

Delete postgres_config.yaml
Delete opensearch_config.yaml

UI:Major Dashboard Change
Changes :

- Font changed: Gilroy to DMSans
- Deleted `ui/src/contexts/ApiContext.ts` and `ui/src/api/LocalApi.ts` (no usage)
- Added New Bootstrap Tooltip and PieChart Components
- Renamed Overview to Overall
- Created a new component called Overview
- In `src/api/Api.ts` changed all interfaces to types
- In Preview, used `React.useEffect` and `React.useState` hooks to make the pie charts responsive
- Added new CSS variable for colours
- In `ui/src/types/component.type.ts` added ‘metric_validation_unchecked’
Comment thread datachecks/core/inspect.py Outdated
Comment thread ui/src/App.tsx Outdated
Comment thread ui/src/App.tsx
Comment thread ui/src/components/Navbar/Navbar.tsx Outdated
Comment thread ui/src/components/Overall/Overall.module.css Outdated
Comment thread ui/src/components/Preview/Preview.tsx Outdated
Comment thread ui/src/components/Preview/Snapshot.tsx Outdated
Comment thread ui/src/components/Tabs/Tabs.module.css Outdated
Comment thread ui/src/components/Tabs/Tabs.tsx Outdated
Comment thread ui/src/components/Tabs/Tabs.tsx Outdated
@driptanil driptanil changed the title UI:Major Dashboard Change feat: Add major dashboard changes Dec 24, 2023
Fixed File and Directory structure, for cleaner code
@driptanil driptanil changed the title feat: Add major dashboard changes feat: major dashboard changes Dec 24, 2023
Comment thread ui/src/App.tsx Outdated
Comment thread ui/src/components/Overall/Overall.tsx Outdated
Comment thread ui/src/components/Preview/Overview/MetricContent/MetricContent.tsx
Comment thread ui/src/components/Preview/Overview/MetricVerticalTabs/VerticalTabs.tsx Outdated
Comment thread ui/src/components/Preview/Overview/MetricVerticalTabs/VerticalTabs.tsx Outdated
@WeryZebra-Yue
Copy link
Copy Markdown
Contributor

Renaming the folder structure ".../UI/..." would be wonderful. @driptanil

@driptanil
Copy link
Copy Markdown
Contributor Author

driptanil commented Jan 1, 2024

Renaming the folder structure ".../UI/..." would be wonderful. @driptanil

Do I rename it to sub-components ?

Please suggest me a name

Comment thread ui/src/components/Overall/Overall.tsx Outdated
Comment thread postgres_config.yaml Outdated
@WeryZebra-Yue WeryZebra-Yue merged commit 2bae2a7 into main Jan 2, 2024
@WeryZebra-Yue WeryZebra-Yue deleted the ui-update branch January 2, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Metric Dashboard ⚡️enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants