Skip to content

Add CTA icon for toast notices and don't display toast notices on smaller screen sizes#24

Merged
codycooperross merged 1 commit intomasterfrom
toast-cta
Mar 18, 2026
Merged

Add CTA icon for toast notices and don't display toast notices on smaller screen sizes#24
codycooperross merged 1 commit intomasterfrom
toast-cta

Conversation

@codycooperross
Copy link
Contributor

Purpose

closes: Add github issue that originated this PR

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@codycooperross codycooperross changed the title Add CTA icon and don't display on smaller screen sizes Add CTA icon for toast notices and don't display toast notices on smaller screen sizes Mar 18, 2026
Copy link
Contributor

@svogt0511 svogt0511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Looks good. One question: I see the icon you are building. Why are you building it instead of using something like fontawesome? (Just curious)

@codycooperross codycooperross merged commit 0f7178e into master Mar 18, 2026
2 checks passed
@codycooperross codycooperross deleted the toast-cta branch March 18, 2026 19:24
@codycooperross
Copy link
Contributor Author

Hi. Looks good. One question: I see the icon you are building. Why are you building it instead of using something like fontawesome? (Just curious)

Thanks, Suzanne! I downloaded the SVG from FontAwesome and plugged it in here. It seemed easier to do that than have a dependency. Does that seem like the right way to go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants