Support for Schema 4.5

[codycooperross]

Purpose

Implements the new Schema 4.5 features and XSD, in particular the expansion of the publisher property to allow for additional attributes.

closes: datacite/lupo#1004 #165

Approach

Modifies readers and writers to support both publisher as a hash with new attributes (publisherIdentifier, publisherIdentifierScheme, etc.) and publisher as a string. Adds tests for reading and writing these attributes.

This PR also fixes an issue described in #165 that resulted in errors when validating the new datacite-example-full-v4.5.xml example, which contains a geoLocationPolygon property.

Open Questions and Pre-Merge TODOs

• This PR does not add support for reading and writing new publisher properties beyond DataCite XML. Mapping from and to other schemas will be part of future work.
• crossref_writer.rb is currently unmodified. Based on this test, it seems like writing Crossref metadata is expected to produce a nil value:

  bolognese/spec/writers/crossref_writer_spec.rb

  Lines 15 to 21 in 7b3e8cd

  	it "from DataCite" do
  	input = "https://doi.org/10.5061/DRYAD.8515"
  	subject = Bolognese::Metadata.new(input: input, from: "datacite")
  	expect(subject.crossref).to be nil
  	end
  	end
  	end

  It appears that Crossref writing functionality is not supported yet. There is a several years old PR that proposed to add this functionality, but it was never merged: https://github.com/datacite/bolognese/pull/126/files

Learning

Types of changes

• Bug fix (non-breaking change which fixes an issue)

• New feature (non-breaking change which adds functionality)

• Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

• Be humble in the language and feedback you give, ask don't tell.
• Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
• Offer suggestions on how to improve code e.g. simplification or expanding clarity.
• Ensure you give reasons for the changes you are proposing.

[codycooperross]

FYI, I tested this branch of bolognese in the current main branch of lupo (prior to the 4.5 feature branch merge). All rspec tests passed, so bolognese should still be deployable in lupo if this branch is merged without any changes to lupo.

[richardhallett]

lgtm

[ashwinisukale]

Hi there :)

Changes looks good to me 🎉 , I have suggested some minor refactoring changes.

Thank you

[ashwinisukale]

Changes looks great to me. Thank you for the work!

[svogt0511]

Added a comment to the last change @codycooperross made to the dc_json writer. Good catch, Cody.