Skip to content

Add events_controller specs#21

Merged
wendelfabianchinsamy merged 1 commit intomainfrom
add-specs
May 15, 2025
Merged

Add events_controller specs#21
wendelfabianchinsamy merged 1 commit intomainfrom
add-specs

Conversation

@wendelfabianchinsamy
Copy link
Contributor

Purpose

closes: datacite/datacite#2339

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@wendelfabianchinsamy wendelfabianchinsamy self-assigned this May 15, 2025
@wendelfabianchinsamy wendelfabianchinsamy merged commit dbc2a0f into main May 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add events_controller specs

1 participant