Skip to content

upgrade nokogiri#33

Merged
wendelfabianchinsamy merged 3 commits intomasterfrom
upgrade-nokogiri
Feb 27, 2024
Merged

upgrade nokogiri#33
wendelfabianchinsamy merged 3 commits intomasterfrom
upgrade-nokogiri

Conversation

@wendelfabianchinsamy
Copy link
Copy Markdown
Contributor

@wendelfabianchinsamy wendelfabianchinsamy commented Feb 27, 2024

Purpose

closes: #32

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@wendelfabianchinsamy wendelfabianchinsamy self-assigned this Feb 27, 2024
@wendelfabianchinsamy wendelfabianchinsamy merged commit 6321330 into master Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade nokogiri

2 participants