Finish updating github workflows and restructure them similar to othe…#65
Merged
Finish updating github workflows and restructure them similar to othe…#65
Conversation
…r project workflows (lupo)
jrhoads
reviewed
Dec 13, 2023
| uses: ./.github/workflows/build.yml | ||
| with: | ||
| image_name: ${{ github.repository }} | ||
| image_tag: main |
Contributor
There was a problem hiding this comment.
Seems like the tag needs to be based on the branch, not main
Contributor
Author
There was a problem hiding this comment.
Great catch. Done.
jrhoads
reviewed
Dec 13, 2023
| needs: [test, call_build_and_push] | ||
| uses: ./.github/workflows/_update_terraform.yml | ||
| with: | ||
| image_tag: main |
Contributor
Author
There was a problem hiding this comment.
Great catch. Done.
jrhoads
approved these changes
Dec 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…r project workflows (lupo)
Purpose
Finish updating and improve the github actions.
Approach
Uses a structure similar to lupo github actions. Finished updating the github marketplace workflows to make sure they are using at least node 16. Removed calls to the slack github marketplace action.
Open Questions and Pre-Merge TODOs
Learning
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: