Upgrade poodle to all latest rails and ruby versions#69
Merged
ashwinisukale merged 14 commits intomasterfrom Nov 14, 2024
Merged
Upgrade poodle to all latest rails and ruby versions#69ashwinisukale merged 14 commits intomasterfrom
ashwinisukale merged 14 commits intomasterfrom
Conversation
ashwinisukale
requested review from
digitaldogsbody,
jrhoads,
kaysiz,
lizkrznarich,
richardhallett,
svogt0511 and
wendelfabianchinsamy
kaysiz
approved these changes
Oct 18, 2024
richardhallett
approved these changes
Oct 18, 2024
jrhoads
approved these changes
Oct 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
closes: #68
Changes:
URI#escape was deprecated and later removed - ruby/uri@61c6a47
From the commit :
This method is obsolete and should not be used. Instead, use
CGI.escape, URI.encode_www_form or URI.encode_www_form_component
depending on your specific use case.
Ruby 3.0.0 onwards URI#escape does not work.
Use CGI.escape or URI.encode_www_form as mentioned in the deprecation warning