Skip to content

Explicitly request facets#24

Merged
codycooperross merged 1 commit intomainfrom
graph-fix
Mar 3, 2026
Merged

Explicitly request facets#24
codycooperross merged 1 commit intomainfrom
graph-fix

Conversation

@codycooperross
Copy link
Copy Markdown
Contributor

@codycooperross codycooperross commented Mar 2, 2026

Purpose

Fixes issue where charts and menu options don't display.

closes: Add github issue that originated this PR

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

Summary by CodeRabbit

  • Improvements
    • Enhanced search query parameters to ensure search filters and faceting options are properly enabled across all search operations.

@codycooperross codycooperross requested a review from a team March 2, 2026 23:12
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Mar 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
puli Ready Ready Preview, Comment Mar 2, 2026 11:12pm

Request Review

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 5ee89aa and 9b609d3.

📒 Files selected for processing (1)
  • src/data/fetch.ts

📝 Walkthrough

Walkthrough

The fetchDois function in src/data/fetch.ts now includes an additional search parameter disable-facets: "false" in the query string. This configuration-level addition does not affect related processing, error handling, or control flow.

Changes

Cohort / File(s) Summary
Query Parameter Addition
src/data/fetch.ts
Added disable-facets: "false" parameter to Dois search query in fetchDois function.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Explicitly request facets' directly reflects the main change: adding disable-facets: false to the Dois search parameters to fix a display issue with charts and menu options.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch graph-fix

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codycooperross codycooperross merged commit 2e3f313 into main Mar 3, 2026
4 checks passed
@bklaing2 bklaing2 deleted the graph-fix branch March 11, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants