Updating nokogiri to new version for security reasons.#41
Merged
richardhallett merged 4 commits intomasterfrom Dec 29, 2017
Merged
Updating nokogiri to new version for security reasons.#41richardhallett merged 4 commits intomasterfrom
richardhallett merged 4 commits intomasterfrom
Conversation
ghost
added
the
mfenner
reviewed
Dec 29, 2017
mfenner
left a comment
mfenner
left a comment
There was a problem hiding this comment.
I suggest to be consistent with all static sites regarding branches and where and when to deploy, compare to https://github.com/datacite/homepage/blob/master/.travis.yml.
So either have all builds go to test as here, or dont build/deploy unless master branch. I guess I prefer the latter, because otherwise every pull request is deployed.
Maybe the exit 1; is the reason pull request builds failed before.
mfenner
approved these changes
Dec 29, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also includes updates to travis to ensure building of PR's on different branches.