Merged
Conversation
Schema v4.2 added the xml:lang attribute to creators, contributors and publisher properties. In the XML schema this property is on the creatorName/contributorName. This commit is not adding the lang attribute to the publisher property as the solution requires further discussion.
According to the v4.2 documentation (18.4.1), the polygon points is a required property if geoLocationPolygons are specified.
The agency property is not part of the official v4.2 documentation and thus should not be a required property.
This was referenced Dec 5, 2022
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on #55 and found as part of merging inveniosoftware/datacite#48
See the individual commits.