feat: CLI review-readiness + deprecazione blocker-hints#245
Merged
Conversation
… schema -c - Nuova CLI `toolkit review-readiness` (--config, --year, --json) - blocker_hints() in schema_ops ora delega a review_readiness() - CLI blocker-hints mostra deprecation warning in output umano - inspect schema ora accetta -c/--config come tutti gli altri comandi - README aggiornato: review-readiness è il comando raccomandato - Test allineati: parquet reali via DuckDB per test che ora verificano leggibilità - Template notebook aggiornato: review-readiness, no pos_cfg workaround - bdap-lea notebook allineato
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nuova CLI
toolkit review-readiness— check di prontezza per review candidate, con classificazione ternaria (ready / needs-review / incomplete).blocker-hintsdeprecato e nascosto dall'help.Cosa cambia
Nuovo
toolkit review-readiness --config X --year Y [--json]— CLI pubblica che chiama la stessa implementazione del tool MCPtoolkit_review_readinessDeprecato
toolkit blocker-hints— nascosto da--help, mostra deprecation warning in output umanoblocker_hints()inschema_ops.py— ora wrapper ~40 righe che delega areview_readiness(), zero logica duplicataFix
toolkit inspect schemaora accetta-c/--configcome tutti gli altri comandi (era posizionale)Docs
run,inspect,scaffold(mancavano nell'help)Test
blocker-hintsallineati alla nuova implementazione (parquet reali via DuckDB)Files toccati
toolkit/cli/cmd_review_readiness.py(nuovo)toolkit/cli/app.pytoolkit/cli/cmd_blocker_hints.pytoolkit/cli/cmd_run.pytoolkit/cli/cmd_scaffold.pytoolkit/cli/inspect/__init__.pytoolkit/cli/inspect/schema_ops.pytoolkit/mcp/schema_ops.pytoolkit/mcp/README.mdtoolkit/README.mdtests/test_cli_blocker_hints.pytests/test_mcp_toolkit_client.pyImpatto downstream
Nessuno —
blocker_hints()resta funzionante (delega). MCP tooltoolkit_blocker_hintsinvariato.