fix: stop injecting implicit __extra csv column#8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7
Summary
Questa PR rimuove l'aggiunta automatica della colonna
__extraquandoclean.read.columnse' gia' definito in modo esplicito.In pratica, il reader ora usa esattamente lo schema dichiarato nel config, senza allargarlo implicitamente.
Perche'
Il comportamento precedente rompeva casi reali a schema fisso:
null_paddingDuckDB riceveva una colonna in piu' rispetto a quelle presenti nel file e falliva in sniff/parsing.
Cosa cambia
__extraintoolkit/clean/duckdb_read.pyCasi reali collegati
stress-local/cases/case_03_siope_no_header_schemastress-local/cases/case_08_pnrr_progetti_m1Questi casi hanno aiutato a identificare e validare il fix nel laboratorio locale.
Testing
Eseguito:
Esito:
26 passedNote
Il laboratorio
stress-localnon fa parte di questa PR.Il branch contiene solo: