Skip to content

[Service Health] Adds the tags for service health dashboard to pickup releases#178

Merged
gmechali merged 3 commits intodatacommonsorg:mainfrom
gmechali:tags
Mar 30, 2026
Merged

[Service Health] Adds the tags for service health dashboard to pickup releases#178
gmechali merged 3 commits intodatacommonsorg:mainfrom
gmechali:tags

Conversation

@gmechali
Copy link
Copy Markdown
Contributor

No description provided.

@gmechali gmechali requested a review from clincoln8 March 27, 2026 18:44
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds environment-specific tags to the deployment configuration files for autopush, release, and staging. The reviewer recommended adding a trailing newline to the autopush and release YAML files to ensure consistency across all configuration files.

Comment thread deploy/autopush.yaml Outdated
options:
logging: CLOUD_LOGGING_ONLY

tags: ['cloudrun::mcp-server-autopush'] No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other configuration files (e.g., deploy/staging.yaml) and to follow common best practices, please add a newline at the end of the file.

tags: ['cloudrun::mcp-server-autopush']

Comment thread deploy/release.yaml Outdated
options:
logging: CLOUD_LOGGING_ONLY

tags: ['cloudrun::mcp-server-prod'] No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other configuration files (e.g., deploy/staging.yaml) and to follow common best practices, please add a newline at the end of the file.

tags: ['cloudrun::mcp-server-prod']

Copy link
Copy Markdown
Contributor

@clincoln8 clincoln8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@gmechali gmechali merged commit 00f731b into datacommonsorg:main Mar 30, 2026
6 checks passed
@gmechali gmechali deleted the tags branch March 30, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants