Data annotator and pvmap generator#1264
Conversation
keyurva
left a comment
There was a problem hiding this comment.
I skimmed the PR and am approving it but would be good to do smaller PRs moving forward. One overall comment is that each script here is a runnable script. If it makes sense, consider exposing only one runner script and invoke others as modules as needed. This can simplify the individual modules and make them more testable.
Thanks Keyur. While each script is can be run separately, all these modules are invoked by the stat_var_processor.py and don't need to be invoked individually. |
Utilities for generating pv-map