RBI sdp updates

[abhishekjaisw]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @abhishekjaisw, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the RBI State Domestic Product data import process. It adjusts the script to accommodate changes in the source data's table structure, extends the data range, and updates metadata and property-value maps to ensure accurate data ingestion and processing. Additionally, new statvar mcf files are added.

Highlights

• RBI SDP Data Update: Updates the RBI State Domestic Product (SDP) data import scripts and metadata to reflect changes in table numbers and extend the data range.
• Table Number Range Adjustment: Adjusts the table number range in rbi_sdp_download.py from 26-57 to 19-52 to match the current data source.
• Metadata and PV Map Updates: Modifies state_domestic_product_metadata.csv and state_domestic_product_pv_map.csv to align with the updated table numbers and extend the end date to 2025.
• Caveat Added to README: Adds a caveat to README.md regarding potential future changes in table numbers and instructions to modify the download script accordingly.
• New StatVar MCF Files: Adds new Statistical Variable MCF files (state_domestic_product_output_stat_vars.mcf and state_domestic_product_output_stat_vars_schema.mcf).

Changelog

• statvar_imports/india_rbistatedomesticproduct/README.md
  • Added a caveat about potential future changes in table numbers and how to adjust the download script.
• statvar_imports/india_rbistatedomesticproduct/rbi_sdp_download.py
  • Modified the table number range to 19-52 to reflect the current data source.
• statvar_imports/india_rbistatedomesticproduct/state_domestic_product_metadata.csv
  • Updated the description to reflect the correct table number (19).
  • Extended the end date to 2025.
  • Commented out header_rows and mapped_rows.
  • Added dc_api_root.
• statvar_imports/india_rbistatedomesticproduct/state_domestic_product_pv_map.csv
  • Updated table numbers to 19 and 20 for per capita net state domestic product.
  • Added FINANCIAL SERVICES as an economicSector.
• statvar_imports/india_rbistatedomesticproduct/test_data/state_domestic_product_output_stat_vars.mcf
  • Added new Statistical Variable MCF file.
• statvar_imports/india_rbistatedomesticproduct/test_data/state_domestic_product_output_stat_vars_schema.mcf
  • Added new Statistical Variable MCF schema file.

Activity

• The pull request modifies the RBI SDP data import scripts.
• The table number range in rbi_sdp_download.py was adjusted.
• The metadata and PV map were updated to align with the new table numbers and extend the data range.
• A caveat was added to the README regarding potential future changes in table numbers.
• New Statistical Variable MCF files were added.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the RBI state domestic product data import scripts and configurations. The main changes involve updating the range of tables to be downloaded, modifying metadata and property-value mappings to reflect the new data source structure, and adding new test files. My feedback focuses on improving maintainability and adhering to coding style conventions. I've suggested improving a comment in the README for clarity, and adding a missing newline at the end of a file to follow Python best practices.