Import workflow fixes#1886
Merged
vish-cs merged 1 commit intodatacommonsorg:masterfrom Mar 13, 2026
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to fix and enhance the import workflow by adding retry logic and improving import list fetching. However, it introduces significant security vulnerabilities, including path traversal in StorageClient methods, which could allow writing blobs to arbitrary GCS locations, and an MCF injection vulnerability due to unsanitized user input in metadata generation. Furthermore, a critical bug in ingestion-helper/main.py prevents import status updates, and there's a medium-severity suggestion for code clarity. It is imperative to address these security flaws and functional issues to ensure the workflow's integrity and secure operation.
78e3ba7 to
4ebba11
Compare
2787715 to
4f7ad69
Compare
e87ff84 to
a27bca7
Compare
ajaits
reviewed
Mar 12, 2026
ajaits
reviewed
Mar 12, 2026
ajaits
reviewed
Mar 12, 2026
ajaits
reviewed
Mar 12, 2026
ajaits
reviewed
Mar 12, 2026
ajaits
reviewed
Mar 12, 2026
ajaits
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.