[DCP - Ingestion] Match the ingestion path #2047
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors storage_client.py by introducing a helper method _get_output_dir to centralize the construction of GCS output directory paths, incorporating an optional prefix from the GCS_OUTPUT_PREFIX environment variable. This helper replaces duplicate path-generation logic across multiple methods. The review feedback suggests using posixpath.join instead of os.path.join to prevent platform-specific path separator issues (e.g., on Windows) since GCS paths must always use forward slashes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is no env var specified, this would be a no-op ensuring this does not change anything for Base DC.
This PR goes in tandem with: datacommonsorg/datacommons#92