Fix some Docker commands to use a variable instead of hard-coded 'custom' directory#696
Fix some Docker commands to use a variable instead of hard-coded 'custom' directory#696kmoscoe merged 63 commits intodatacommonsorg:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates documentation for the custom Data Commons setup, including improvements to volume mounting instructions and clarifications regarding input directory configurations. A review comment identified a missing slash in a volume mount path within 'custom_dc/build_image.md', which has been addressed with the provided suggestion.
nick-nlb
left a comment
nick-nlb
left a comment
There was a problem hiding this comment.
LGTM, with the only required change before merging the typo, and the otherone optional.
| </div> | ||
| </div> | ||
|
|
||
| - The project directory is the directory you have set up for your development environment, as described in [Set up your environment](custom_ui.md#setup) (or `custom` if you are using the default). |
There was a problem hiding this comment.
To make a clear visual link to the lines above:
The <var>PROJECT_DIRECTORY</var> is the directory
(This is a very optional change and up to your preference of course).
There was a problem hiding this comment.
Yeah, I debated about this and went back and forth on it. The problem is that when there are a lot of variables to explain, it gets hard to read. (If I do it here, I should do it everywhere.) Let me think about it some more...
2 participants
AS a follow-up to PR #693, this fixes some Docker commands that were using 'custom' directory in file paths. It also makes some other updates to custom data docs to make the input directory more clear.