Deprecate covid19-dashboard#323
Conversation
Summary of ChangesHello @n-h-diaz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly streamlines the repository by removing the unmaintained DC COVID-19/Social Wellness Dashboard and the associated DC Tools Default App. This strategic cleanup addresses technical debt, eliminates outdated dependencies, and aligns the codebase with the current V0/V1 migration, ensuring a more focused and manageable project going forward. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request deprecates the covid19-dashboard and default applications by deleting their respective directories. This is a welcome cleanup of unmaintained tools. While the file deletions are comprehensive, I've identified a critical issue: the dispatch.yaml file, which is not part of this pull request, still contains routing rules for the dashboard service that is being removed. This will likely cause deployment failures. I have left a comment on the relevant deleted file with a recommendation to address this. With that fix, this PR will be ready.
Deprecates the DC COVID-19/Social Wellness Dashboard (https://github.com/datacommonsorg/tools/tree/master/covid19-dashboard) and DC Tools Default App (https://github.com/datacommonsorg/tools/tree/master/default)
These tools are not being maintained and are using very old versions which are now incompatible. The hosting GCP project (datcom-tools-staging) has been deleted.
This is part of a code cleanup for the V0/V1 migration. We can revert this change if the tools are needed again.