[Browser] Catch name fetch errors for page rendering; Use V1 API to fetch properties#1846
Merged
shifucun merged 3 commits intodatacommonsorg:masterfrom Nov 18, 2022
Merged
[Browser] Catch name fetch errors for page rendering; Use V1 API to fetch properties#1846shifucun merged 3 commits intodatacommonsorg:masterfrom
shifucun merged 3 commits intodatacommonsorg:masterfrom
Conversation
beets
approved these changes
Nov 18, 2022
| result[dcid] = '' | ||
| if dcid in response: | ||
| values = response[dcid] | ||
| if values: |
Collaborator
There was a problem hiding this comment.
perhaps: if values and len(values)? i'm slightly uncomfortable simply calling values[0]
Comment on lines
+36
to
+38
| node_name = shared_api.names([dcid]).get(dcid) | ||
| if not node_name: | ||
| node_name = dcid |
Collaborator
There was a problem hiding this comment.
since node_name is already dcid by default, maybe instead:
try:
api_name = shared_api.names...
if api_name:
node_name = api_name
shifucun
commented
Nov 18, 2022
Contributor
Author
shifucun
left a comment
shifucun
left a comment
There was a problem hiding this comment.
thanks for review!
| result[dcid] = '' | ||
| if dcid in response: | ||
| values = response[dcid] | ||
| if values: |
Comment on lines
+36
to
+38
| node_name = shared_api.names([dcid]).get(dcid) | ||
| if not node_name: | ||
| node_name = dcid |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.