[Disaster Pages] Initial Page Setup#1848
Merged
juliawu merged 4 commits intodatacommonsorg:masterfrom Nov 29, 2022
Merged
Conversation
beets
reviewed
Nov 28, 2022
| return flask.render_template('dev/disaster_dashboard.html', | ||
| european_countries=european_countries) | ||
|
|
||
| @bp.route('/event-page') |
Collaborator
There was a problem hiding this comment.
nit: "event" rather than "event-page" since they're all pages. drop the "-page" for the route and filenames too
Contributor
Author
There was a problem hiding this comment.
Renamed all event-page instances to event
| */ | ||
|
|
||
| /** | ||
| * disaster dashboard |
| * Types specific to Event Page | ||
| */ | ||
|
|
||
| export interface EventInfo { |
Collaborator
There was a problem hiding this comment.
in general, please add documentation for shared interfaces.
can we add this type as it's needed?
Contributor
Author
There was a problem hiding this comment.
I meant it as a placeholder, removed the interface. Will add types as necessary in future PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets up skeleton for dedicated event pages which will eventually contain information, maps, news, etc about each natural disaster event in the disaster dashboard. Current PR is for a blank page. Future PRs will fill in with info.