Skip to content

[v0/v1 migration] Remove all trailing instances of sparql#6072

Merged
juliawu merged 2 commits intodatacommonsorg:masterfrom
juliawu:remove-sparql
Mar 10, 2026
Merged

[v0/v1 migration] Remove all trailing instances of sparql#6072
juliawu merged 2 commits intodatacommonsorg:masterfrom
juliawu:remove-sparql

Conversation

@juliawu
Copy link
Copy Markdown
Contributor

@juliawu juliawu commented Mar 10, 2026

Removes all remaining instances of the (v0) /sparql API from this repository.

As far as I can tell, the actual usage of /sparql and dc.query() which wrapped /sparql have already been removed. This PR just adds some final cleanup to remove trailing references to it.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request finalizes the migration away from the deprecated v0 /sparql API. It systematically removes all remaining code, configuration, and documentation references to the old SPARQL endpoint, ensuring a complete cleanup of the codebase after its functionality was previously replaced.

Highlights

  • API Deprecation Cleanup: Removed the query function from server/services/datacommons.py, which previously handled /v2/sparql requests.
  • Endpoint Configuration Update: Deprecated the /v2/sparql endpoint by removing it from the list of known service URLs in server/services/discovery.py.
  • Test Case Refinement: Updated test cases in server/tests/services/discovery_test.py to reflect the removal of the /v2/sparql endpoint.
  • Ingress Configuration Cleanup: Cleaned up ingress configuration files (server/tests/test_data/ingress/test1.yaml and server/tests/test_data/ingress/test2.yaml) by removing mappings for /v2/sparql.
  • Documentation and Comments Update: Updated documentation and comments in tools/sitemap/README.md and tools/sitemap/main.py to remove references to the old SPARQL API.
Changelog
  • server/services/datacommons.py
    • Removed the query function.
  • server/services/discovery.py
    • Removed /v2/sparql from the list of known endpoints.
  • server/tests/services/discovery_test.py
    • Removed assertions related to the /v2/sparql endpoint URL.
  • server/tests/test_data/ingress/test1.yaml
    • Removed the query-host mapping for /v2/sparql.
  • server/tests/test_data/ingress/test2.yaml
    • Removed the bq-service mapping for /v2/sparql.
  • tools/sitemap/README.md
    • Updated text to remove "sparql" from "python sparql API".
  • tools/sitemap/main.py
    • Updated comment to replace "sparql" with "mixer".
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes all remaining instances of the /sparql API from the repository. The changes include removing the query function in datacommons.py, the /v2/sparql endpoint from discovery.py, and associated tests and test data. References to sparql in documentation and code comments have also been removed or updated. The changes are consistent with the goal of removing the deprecated API.

@juliawu juliawu requested a review from n-h-diaz March 10, 2026 21:48
Copy link
Copy Markdown
Contributor

@n-h-diaz n-h-diaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@juliawu juliawu marked this pull request as ready for review March 10, 2026 22:14
@juliawu juliawu merged commit 168884f into datacommonsorg:master Mar 10, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants