Move FLASK_ENV option out of "rarely need to be changed" to the "Directories" section and fix incorrect description#6093
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the custom_dc/env.list.sample configuration file by repositioning the FLASK_ENV variable and providing a significantly improved and accurate description. The changes aim to clarify the critical role of FLASK_ENV in managing custom environments, particularly for users who are customizing their deployments, thereby helping them avoid potential configuration errors and merge conflicts during future updates. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly moves the FLASK_ENV configuration to a more appropriate section in the env.list.sample file and updates its description to be more accurate and helpful for users setting up a custom Data Commons instance. My feedback focuses on improving the readability of the new comment.
The description erroneously claimed that this controls the directory containing static assets, i.e. static/custom_dc, which is not the case; it's controlled by server/config/app_env/config.py. In addition, it's actually necessary to set this if you're going to do any customization and don't want to get stomped/encounter merge conflicts every time you resync to the stable release.
A follow-on PR will update the UI customization doc in Docsite.