Skip to content

[v0/v1] [Ranking page revamp] Add feature flag for ranking pages#6094

Merged
juliawu merged 3 commits intodatacommonsorg:masterfrom
juliawu:ranking-revamp-flag
Mar 17, 2026
Merged

[v0/v1] [Ranking page revamp] Add feature flag for ranking pages#6094
juliawu merged 3 commits intodatacommonsorg:masterfrom
juliawu:ranking-revamp-flag

Conversation

@juliawu
Copy link
Copy Markdown
Contributor

@juliawu juliawu commented Mar 17, 2026

Adds a new_ranking_page feature flag for the revamp of the ranking pages.

As part of the v0/v1 migration, we are doing a simple revamp of the ranking pages. Adding this flag will allow me to more easily break up the changes into smaller PRs without affecting the production pages, which generate a lot of SEO traffic.

The flag is set to enabled by default on autopush and local, and false by default for dev and staging. There is no flag set for production.

@juliawu juliawu requested a review from nick-nlb March 17, 2026 22:40
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new feature flag, "new_ranking_page", across various environment configuration files. This flag is a foundational step for the upcoming revamp of the ranking pages, allowing the author to incrementally develop and deploy changes in subsequent PRs. By establishing this flag, the project can manage the rollout of the new UI, ensuring that changes can be tested and released without immediately impacting the critical SEO performance of existing production pages during the v0/v1 migration.

Highlights

  • Feature Flag Introduction: A new feature flag, "new_ranking_page", has been introduced across multiple environment configurations to enable a phased rollout of revamped ranking pages. This flag is initially set to "false" in all configurations within this PR, providing a mechanism to control the new UI's visibility without immediately affecting production SEO traffic.
Changelog
  • server/config/feature_flag_configs/autopush.json
    • Added the "new_ranking_page" feature flag configuration.
  • server/config/feature_flag_configs/custom.json
    • Added the "new_ranking_page" feature flag configuration.
  • server/config/feature_flag_configs/dev.json
    • Added the "new_ranking_page" feature flag configuration.
  • server/config/feature_flag_configs/local.json
    • Added the "new_ranking_page" feature flag configuration.
  • server/config/feature_flag_configs/staging.json
    • Added the "new_ranking_page" feature flag configuration.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the new_ranking_page feature flag to support the revamp of the ranking pages. The changes correctly add the flag to the configuration files for various environments. However, there's a discrepancy between the implementation and the description for the autopush and local environments, where the flag is disabled instead of enabled. Please update these configurations to match the intended behavior.

Comment thread server/config/feature_flag_configs/autopush.json Outdated
Comment thread server/config/feature_flag_configs/local.json Outdated
Copy link
Copy Markdown
Contributor

@nick-nlb nick-nlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliawu juliawu enabled auto-merge (squash) March 17, 2026 22:49
@juliawu juliawu merged commit bd729f4 into datacommonsorg:master Mar 17, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants