Skip to content

Automated Integration Test Goldens Update from CI#6098

Merged
SandeepTuniki merged 1 commit intomigrate-place-info-v2-golden-updatesfrom
nl-golden-update-89397212-0490-4b54-9d0c-4c13795f46b5
Mar 18, 2026
Merged

Automated Integration Test Goldens Update from CI#6098
SandeepTuniki merged 1 commit intomigrate-place-info-v2-golden-updatesfrom
nl-golden-update-89397212-0490-4b54-9d0c-4c13795f46b5

Conversation

@datacommons-robot-author
Copy link
Collaborator

@datacommons-robot-author datacommons-robot-author commented Mar 18, 2026

This pull request updates the golden files automatically via Cloud Build. Please review the changes carefully. Cloud Build Log

Edit from @SandeepTuniki: Don't review/approve. I triggered this PR creation manually (through cloudbuild) as part of my work in #6047. I'll club the changes of this PR into #6047.

@datacommons-robot-author datacommons-robot-author requested review from a team and clincoln8 and removed request for a team March 18, 2026 06:06
@SandeepTuniki SandeepTuniki removed the request for review from clincoln8 March 18, 2026 06:07
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request contains automated updates to integration test golden files. The primary purpose of these changes is to standardize the representation of the country 'United States' to its more formal name, 'United States of America,' across various chart configuration and debug information JSON files. These updates ensure that the test outputs align with the desired naming conventions and reflect the latest expected golden states.

Highlights

  • Golden File Updates: Updated numerous integration test golden files to reflect changes in expected output, primarily standardizing the naming of 'United States' to 'United States of America'.
  • Consistency in Place Naming: Ensured consistent use of 'United States of America' across various chart configuration and debug information JSON files.
  • Minor Numerical Adjustments: Included slight floating-point number updates in specific debug information JSON files.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@SandeepTuniki SandeepTuniki merged commit 9804dfd into migrate-place-info-v2-golden-updates Mar 18, 2026
1 of 2 checks passed
@SandeepTuniki SandeepTuniki deleted the nl-golden-update-89397212-0490-4b54-9d0c-4c13795f46b5 branch March 18, 2026 06:08
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request automatically updates golden files for integration tests. The majority of changes involve updating the place name from "United States" to "United States of America", which is a consistent and appropriate change. However, I've noticed a couple of instances where floating-point scores in test data have been updated with increased precision. According to the repository's general rules, scores should be rounded to a consistent, lower precision to improve test robustness and reduce noise from minor model variations. I've left specific comments with suggestions to adhere to this rule.

0.38534,
0.38184,
0.3797
0.37971
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The precision of this score has been increased from 4 to 5 decimal places. To improve test robustness against minor model output variations, it's recommended to use a consistent, lower precision for floating-point scores in test data.

While this change makes the precision consistent with other values in this list, it increases the precision which can lead to test brittleness. I suggest we round this value to 3 decimal places. For overall consistency, it would be best to apply this rounding to all scores in this list in a follow-up.

Suggested change
0.37971
0.380
References
  1. Round floating-point scores in test data to a consistent, lower precision. This makes tests more robust against insignificant model output variations and reduces review noise.

0.63227,
0.63222,
0.6305,
0.63049,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The precision of this score has been increased from 4 to 5 decimal places. To improve test robustness, our general rules recommend using a consistent, lower precision for floating-point scores.

This list of scores already has inconsistent precision. Instead of increasing precision, I suggest we round this value to 3 decimal places. For overall consistency, it would be best to apply this rounding to all scores in this list in a follow-up.

Suggested change
0.63049,
0.630,
References
  1. Round floating-point scores in test data to a consistent, lower precision. This makes tests more robust against insignificant model output variations and reduces review noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants