[v0/v1 migration] Replace /v1/bulk/find/entities#6110
[v0/v1 migration] Replace /v1/bulk/find/entities#6110nick-nlb merged 4 commits intodatacommonsorg:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the entity finding mechanism to utilize a newer Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully migrates the find_entities function from using the deprecated /v1/bulk/find/entities endpoint to the /v2/resolve endpoint. The corresponding endpoint definition has also been removed. The implementation looks correct. I've added one suggestion to improve the robustness and conciseness of the DCID extraction logic.
Issue
b/459855067
Description
This PR converts the usage of
v1/bulk/find/entitiesto v2 resolve.Testing
To test this path, you need to have detector mode set to
llm, as in:Search
You will need to start your Flask server with LLM_KEY="..." prefixed to the
./run_server.shcommand. Contact @nick-nlb for information on getting a key if required.The searches should produce identical results both pre and post this change. You can verify that, with llm on, that you are following this new path by printing the response in Python.