Skip to content

Automated Integration Test Goldens Update from CI#6136

Merged
shixiao-coder merged 1 commit intomasterfrom
nl-golden-update-3836f5c4-0c55-4374-bc64-81986dc1596d
Mar 27, 2026
Merged

Automated Integration Test Goldens Update from CI#6136
shixiao-coder merged 1 commit intomasterfrom
nl-golden-update-3836f5c4-0c55-4374-bc64-81986dc1596d

Conversation

@datacommons-robot-author
Copy link
Copy Markdown
Collaborator

This pull request updates the golden files automatically via Cloud Build. Please review the changes carefully. Cloud Build Log

@datacommons-robot-author datacommons-robot-author requested review from a team and clincoln8 and removed request for a team March 27, 2026 01:38
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request contains an automated update to the integration test golden files, ensuring that the test data remains synchronized with the latest changes in the application's output.

Highlights

  • Golden File Update: Updated the chart configuration for the 'stateswithhighestphds' integration test to include a new classification entry.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the test data configuration in chart_config.json by adding a new classification entry that includes a quantity filter. A review comment points out that the floating-point value used (2.2250738585072014e-308) is likely an uninitialized minimum value and suggests replacing it with 0.0 to ensure test robustness and follow precision guidelines.

"idx": 0,
"qval": {
"cmp": "GE",
"val": 2.2250738585072014e-308
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The value 2.2250738585072014e-308 is suspicious. This value is equivalent to sys.float_info.min, the smallest positive normalized double-precision number. Its presence here strongly suggests a potential bug in the quantity detection logic, where an uninitialized or default value might be leaking into the results.

According to our guidelines, floating-point values in test data should be rounded to a lower precision to make tests more robust. This extremely precise and small number is likely unintended.

If the goal is to filter for values greater than or equal to zero, 0.0 would be a much clearer and more stable choice.

Suggested change
"val": 2.2250738585072014e-308
"val": 0.0
References
  1. Round floating-point scores in test data to a consistent, lower precision. This makes tests more robust against insignificant model output variations and reduces review noise.

Copy link
Copy Markdown
Contributor

@shixiao-coder shixiao-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shixiao-coder shixiao-coder merged commit a2911ca into master Mar 27, 2026
13 checks passed
@shixiao-coder shixiao-coder deleted the nl-golden-update-3836f5c4-0c55-4374-bc64-81986dc1596d branch March 27, 2026 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants