Skip to content

[v0/v1] Migrate website to /v2/recognize/places #6139

Merged
rohitkumarbhagat merged 4 commits intodatacommonsorg:masterfrom
rohitkumarbhagat:sg-recognize-places
Mar 31, 2026
Merged

[v0/v1] Migrate website to /v2/recognize/places #6139
rohitkumarbhagat merged 4 commits intodatacommonsorg:masterfrom
rohitkumarbhagat:sg-recognize-places

Conversation

@rohitkumarbhagat
Copy link
Copy Markdown
Contributor

  • /v2/recognize/places - new endpoint is live in staging and inline for next prod rollout.
  • Tested locally, goldens are passing

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request migrates the website's place recognition functionality to use the updated v2 API endpoint. This change ensures the application utilizes the latest service version, which has been verified in staging and is prepared for production deployment.

Highlights

  • Endpoint Migration: Updated the recognize_places service to point to the new /v2/recognize/places endpoint.
  • Configuration Update: Added the /v2/recognize/places path to the discovery service allowlist.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the recognize_places function in server/services/datacommons.py to utilize the /v2/recognize/places endpoint and adds this new path to the discovery service configuration. A review comment suggests removing the now-obsolete /v1/recognize/places endpoint from the discovery list to ensure the configuration remains clean and prevents accidental usage of the old version.

Comment thread server/services/discovery.py
Copy link
Copy Markdown
Contributor

@juliawu juliawu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rohitkumarbhagat rohitkumarbhagat enabled auto-merge (squash) March 31, 2026 11:56
@rohitkumarbhagat rohitkumarbhagat merged commit 6ef302f into datacommonsorg:master Mar 31, 2026
13 checks passed
juliawu added a commit that referenced this pull request Apr 1, 2026
This PR puts the change made by Rohit in #6139 behind the `use_v2_api`
feature flag.
@rohitkumarbhagat rohitkumarbhagat deleted the sg-recognize-places branch April 6, 2026 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants