Remove e2e_triple bio tests

[nick-nlb]

Description

This pr removes the e2e_triple explore test (which hits a now deprecated mixer endpoint).

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request cleans up the integration test suite by removing a specific end-to-end test case that relied on a deprecated mixer endpoint. This change helps maintain the reliability of the test suite by eliminating dependencies on outdated infrastructure.

Highlights

• Test Removal: Removed the 'test_e2e_triple' integration test from the explore test suite.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes the test_e2e_triple integration test from the explore tests. The reviewer suggests that the underlying TRIPLE query implementation and the server/lib/nl/fulfillment/triple.py file should also be removed to eliminate dead code, as they appear to be obsolete.

I am having trouble creating individual review comments. Click here to see my feedback.

server/integration_tests/explore_test.py (754-783)

Since this test is being removed because it relies on a deprecated endpoint, the associated TRIPLE query functionality appears to be obsolete. To improve code maintainability by removing dead code, please consider also removing the implementation for TRIPLE queries.

This would likely include:

• Deleting the server/lib/nl/fulfillment/triple.py file.
• Removing the logic that handles QueryType.TRIPLE in server/lib/nl/fulfillment/fulfiller.py.

Addressing this in the current PR would be ideal, but a follow-up is also fine.

[nick-nlb]

Code Review

This pull request removes the test_e2e_triple integration test from the explore tests. The reviewer suggests that the underlying TRIPLE query implementation and the server/lib/nl/fulfillment/triple.py file should also be removed to eliminate dead code, as they appear to be obsolete.

I am having trouble creating individual review comments. Click here to see my feedback.

server/integration_tests/explore_test.py (754-783)

Since this test is being removed because it relies on a deprecated endpoint, the associated TRIPLE query functionality appears to be obsolete. To improve code maintainability by removing dead code, please consider also removing the implementation for TRIPLE queries.

This would likely include:

• Deleting the server/lib/nl/fulfillment/triple.py file.
• Removing the logic that handles QueryType.TRIPLE in server/lib/nl/fulfillment/fulfiller.py.

Addressing this in the current PR would be ideal, but a follow-up is also fine.

Removal of dead code is a separate task that will require careful vetting. The priority here is the removal of a deprecated failing test.

[juliawu]

Thank you for the fix!