Skip to content

The end point was deployed to us-central only and now it deploy to both us-central and us-west#6151

Merged
shixiao-coder merged 2 commits intodatacommonsorg:masterfrom
shixiao-coder:update-config-map
Mar 30, 2026
Merged

The end point was deployed to us-central only and now it deploy to both us-central and us-west#6151
shixiao-coder merged 2 commits intodatacommonsorg:masterfrom
shixiao-coder:update-config-map

Conversation

@shixiao-coder
Copy link
Copy Markdown
Contributor

The missing config map deployment was causing miss match for v2 API on node/bulk/variable

…th us-central and us-west

The missing config map deployment was causing miss match for v2 API on node/bulk/variable
@shixiao-coder shixiao-coder requested a review from gmechali March 30, 2026 21:27
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the cloud deployment process to ensure consistency across multiple regions. By expanding the target locations and iterating through them during the configuration update phase, it resolves issues where missing ConfigMaps were causing API mismatches.

Highlights

  • Multi-region deployment: Updated the deployment script to target both us-west1 and us-central1 regions instead of only us-central1.
  • ConfigMap synchronization: Implemented a loop to ensure the service-config-configmap is correctly created or updated across all target GKE clusters.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the deployment script to support multi-regional deployments by iterating over a list of locations to update the service configuration configmap across multiple GKE clusters. A review comment points out that hardcoding multiple regions will cause the script to fail in single-region environments (e.g., staging) and provides a suggestion to make the location list environment-specific.

Comment thread scripts/deploy_cloud_esp.sh Outdated
# Get gke credentials
echo "Getting GKE credentials for $CLUSTER_NAME in $LOCATION..."
gcloud container clusters get-credentials $CLUSTER_NAME --region=$LOCATION --project=$PROJECT_ID
LOCATIONS=("us-west1" "us-central1")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Hardcoding LOCATIONS to both us-west1 and us-central1 will cause the script to fail for environments that are not multi-regional. For example, the provided staging.yaml only defines us-central1 in its configuration. Since set -e is enabled, the script will exit with an error when attempting to fetch credentials for a non-existent cluster in us-west1. It is recommended to make the locations list environment-specific.

Suggested change
LOCATIONS=("us-west1" "us-central1")
if [[ "$ENV" == "prod" ]]; then
LOCATIONS=("us-west1" "us-central1")
else
LOCATIONS=("us-central1")
fi

@shixiao-coder shixiao-coder merged commit 1676d78 into datacommonsorg:master Mar 30, 2026
13 checks passed
@shixiao-coder shixiao-coder deleted the update-config-map branch March 30, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants