The end point was deployed to us-central only and now it deploy to both us-central and us-west#6151
Conversation
…th us-central and us-west The missing config map deployment was causing miss match for v2 API on node/bulk/variable
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the cloud deployment process to ensure consistency across multiple regions. By expanding the target locations and iterating through them during the configuration update phase, it resolves issues where missing ConfigMaps were causing API mismatches. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the deployment script to support multi-regional deployments by iterating over a list of locations to update the service configuration configmap across multiple GKE clusters. A review comment points out that hardcoding multiple regions will cause the script to fail in single-region environments (e.g., staging) and provides a suggestion to make the location list environment-specific.
| # Get gke credentials | ||
| echo "Getting GKE credentials for $CLUSTER_NAME in $LOCATION..." | ||
| gcloud container clusters get-credentials $CLUSTER_NAME --region=$LOCATION --project=$PROJECT_ID | ||
| LOCATIONS=("us-west1" "us-central1") |
There was a problem hiding this comment.
Hardcoding LOCATIONS to both us-west1 and us-central1 will cause the script to fail for environments that are not multi-regional. For example, the provided staging.yaml only defines us-central1 in its configuration. Since set -e is enabled, the script will exit with an error when attempting to fetch credentials for a non-existent cluster in us-west1. It is recommended to make the locations list environment-specific.
| LOCATIONS=("us-west1" "us-central1") | |
| if [[ "$ENV" == "prod" ]]; then | |
| LOCATIONS=("us-west1" "us-central1") | |
| else | |
| LOCATIONS=("us-central1") | |
| fi |
The missing config map deployment was causing miss match for v2 API on node/bulk/variable