Skip to content

[v0/v1 migration] Add v2 migration flag to production#6161

Merged
nick-nlb merged 3 commits intodatacommonsorg:masterfrom
nick-nlb:v2_migration_feature_flags_production
Apr 8, 2026
Merged

[v0/v1 migration] Add v2 migration flag to production#6161
nick-nlb merged 3 commits intodatacommonsorg:masterfrom
nick-nlb:v2_migration_feature_flags_production

Conversation

@nick-nlb
Copy link
Copy Markdown
Contributor

@nick-nlb nick-nlb commented Apr 1, 2026

Description

This PR adds the use_v2_api flag to production, initially set to false.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new feature flag to the production environment to support the upcoming migration to V2 REST APIs. By adding this configuration, the team can control the rollout of V2-dependent features while keeping them disabled by default.

Highlights

  • Feature Flag Addition: Added the 'use_v2_api' feature flag to the production configuration.
  • Default State: Set the 'use_v2_api' flag to 'false' by default to ensure a safe rollout.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new feature flag, 'use_v2_api', to the production configuration to support the migration to V2 REST APIs. The reviewer suggested clarifying the flag's description to better reflect its purpose and recommended defining a constant in the backend code to avoid hardcoded strings.

Comment thread server/config/feature_flag_configs/production.json
Comment thread server/config/feature_flag_configs/production.json
@nick-nlb nick-nlb marked this pull request as ready for review April 1, 2026 17:52
@nick-nlb nick-nlb requested review from gmechali and juliawu April 1, 2026 17:53
Copy link
Copy Markdown
Contributor

@gmechali gmechali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nick!

So as a reminder, when you submit this, all the production nodes will restart. Though it shouldnt affect the actual code running since it's set to false. But pls only submit this during work hours to ensure if there's an issue, people are ready to respond!

@nick-nlb nick-nlb merged commit ccb41cf into datacommonsorg:master Apr 8, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants