[v0/v1 migration] Add v2 migration flag to production#6161
[v0/v1 migration] Add v2 migration flag to production#6161nick-nlb merged 3 commits intodatacommonsorg:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new feature flag to the production environment to support the upcoming migration to V2 REST APIs. By adding this configuration, the team can control the rollout of V2-dependent features while keeping them disabled by default. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a new feature flag, 'use_v2_api', to the production configuration to support the migration to V2 REST APIs. The reviewer suggested clarifying the flag's description to better reflect its purpose and recommended defining a constant in the backend code to avoid hardcoded strings.
gmechali
left a comment
There was a problem hiding this comment.
Thanks Nick!
So as a reminder, when you submit this, all the production nodes will restart. Though it shouldnt affect the actual code running since it's set to false. But pls only submit this during work hours to ensure if there's an issue, people are ready to respond!
Description
This PR adds the
use_v2_apiflag to production, initially set to false.