Create a feature flag for 3 Flash to help migrate from 2.5 Flash#6162
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new feature flag to manage the transition to Gemini 3 Flash for natural language detection. By centralizing this toggle in the configuration files and updating the internal feature flag library, the team can safely control the rollout of the new model across different deployment environments. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new feature flag, enable_gemini_3_flash, for NL detection across multiple environment configuration files and defines the corresponding constant in feature_flags.py. Feedback focuses on maintaining alphabetical order and consistent verb tense in the JSON configurations to ensure consistency, as well as a suggestion to enable the flag by default in the development environment.
| ENABLE_STAT_VAR_AUTOCOMPLETE = 'enable_stat_var_autocomplete' | ||
| ENABLE_NL_AGENT_DETECTOR = 'enable_nl_agent_detector' | ||
| NEW_RANKING_PAGE = 'new_ranking_page' | ||
| ENABLE_GEMINI_3_FLASH = 'enable_gemini_3_flash' |
There was a problem hiding this comment.
This should go in with the code, not the PR to update feature flags!
Think about it this way, if this somehow breaks all the environments, we want to revert just the feature flags, so we wouldnt be able to revert this PR because it also has this line of code.
Just move that in the other PR and we're good :)
| }, | ||
| { | ||
| "name": "enable_gemini_3_flash", | ||
| "enabled": true, |
There was a problem hiding this comment.
Can you make all the defaults be FALSE
Then when you've submitted the code and you're ready to test in the environments, we can re enable it?
Otherwise we run into the same issue where a rleease to that environment is affecting the code being run which is a more dangerous pattern.
2 participants
No description provided.