Skip to content

Update nodejs_query_differ goldens#6177

Merged
n-h-diaz merged 1 commit intodatacommonsorg:masterfrom
n-h-diaz:golden
Apr 6, 2026
Merged

Update nodejs_query_differ goldens#6177
n-h-diaz merged 1 commit intodatacommonsorg:masterfrom
n-h-diaz:golden

Conversation

@n-h-diaz
Copy link
Copy Markdown
Contributor

@n-h-diaz n-h-diaz commented Apr 6, 2026

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the golden files used for testing the nodejs_query_differ tool. These changes are necessary to align the test expectations with the most recent data refresh, ensuring that the query differ tool continues to function correctly against updated data sources.

Highlights

  • Golden Data Refresh: Updated the golden files for nodejs_query_differ to reflect the latest data refresh, ensuring consistency with current datasets.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several golden test files, including map_rank.json, scatter.json, and timeline_all.json, to reflect data for the year 2024 and adjust associated values. Feedback was provided to round floating-point values in map_rank.json to a lower precision to ensure test robustness against minor variations.

},
{
"dataCsv": "label,Prevalence of Obesity\r\n2022,28.369354377079773\r\n2021,28.762210090520952\r\n2020,28.988876664128732\r\n2018,26.533458367011452\r\n2017,24.749332155529576\r\n2016,24.878941888621977\r\n2015,24.35945707288802\r\n2014,24.726810930702747",
"dataCsv": "label,Prevalence of Obesity\r\n2022,28.36935437707979\r\n2021,28.762210090520895\r\n2020,28.98887666412877\r\n2018,26.533458367011413\r\n2017,24.749332155529572\r\n2016,24.878941888621966\r\n2015,24.359457072888013\r\n2014,24.726810930702737",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The floating-point values in this CSV string have excessive precision. According to the general rules, floating-point scores in test data should be rounded to a consistent, lower precision to make tests more robust against insignificant model output variations and reduce review noise.

Suggested change
"dataCsv": "label,Prevalence of Obesity\r\n2022,28.36935437707979\r\n2021,28.762210090520895\r\n2020,28.98887666412877\r\n2018,26.533458367011413\r\n2017,24.749332155529572\r\n2016,24.878941888621966\r\n2015,24.359457072888013\r\n2014,24.726810930702737",
"dataCsv": "label,Prevalence of Obesity\r\n2022,28.37\r\n2021,28.76\r\n2020,28.99\r\n2018,26.53\r\n2017,24.75\r\n2016,24.88\r\n2015,24.36\r\n2014,24.73",
References
  1. Round floating-point scores in test data to a consistent, lower precision. This makes tests more robust against insignificant model output variations and reduces review noise.

"highlight": {
"date": "2022",
"value": 28.369354377079773
"value": 28.36935437707979
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Round this floating-point value to a lower precision to match the suggested rounding in the dataCsv field and adhere to the general rule regarding test data robustness.

Suggested change
"value": 28.36935437707979
"value": 28.37
References
  1. Round floating-point scores in test data to a consistent, lower precision. This makes tests more robust against insignificant model output variations and reduces review noise.

Copy link
Copy Markdown
Contributor

@dhotchkiss dhotchkiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Natalie

@n-h-diaz n-h-diaz merged commit 76908a0 into datacommonsorg:master Apr 6, 2026
13 checks passed
@n-h-diaz n-h-diaz deleted the golden branch April 6, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants