Update nodejs_query_differ goldens#6177
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the golden files used for testing the nodejs_query_differ tool. These changes are necessary to align the test expectations with the most recent data refresh, ensuring that the query differ tool continues to function correctly against updated data sources. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates several golden test files, including map_rank.json, scatter.json, and timeline_all.json, to reflect data for the year 2024 and adjust associated values. Feedback was provided to round floating-point values in map_rank.json to a lower precision to ensure test robustness against minor variations.
| }, | ||
| { | ||
| "dataCsv": "label,Prevalence of Obesity\r\n2022,28.369354377079773\r\n2021,28.762210090520952\r\n2020,28.988876664128732\r\n2018,26.533458367011452\r\n2017,24.749332155529576\r\n2016,24.878941888621977\r\n2015,24.35945707288802\r\n2014,24.726810930702747", | ||
| "dataCsv": "label,Prevalence of Obesity\r\n2022,28.36935437707979\r\n2021,28.762210090520895\r\n2020,28.98887666412877\r\n2018,26.533458367011413\r\n2017,24.749332155529572\r\n2016,24.878941888621966\r\n2015,24.359457072888013\r\n2014,24.726810930702737", |
There was a problem hiding this comment.
The floating-point values in this CSV string have excessive precision. According to the general rules, floating-point scores in test data should be rounded to a consistent, lower precision to make tests more robust against insignificant model output variations and reduce review noise.
| "dataCsv": "label,Prevalence of Obesity\r\n2022,28.36935437707979\r\n2021,28.762210090520895\r\n2020,28.98887666412877\r\n2018,26.533458367011413\r\n2017,24.749332155529572\r\n2016,24.878941888621966\r\n2015,24.359457072888013\r\n2014,24.726810930702737", | |
| "dataCsv": "label,Prevalence of Obesity\r\n2022,28.37\r\n2021,28.76\r\n2020,28.99\r\n2018,26.53\r\n2017,24.75\r\n2016,24.88\r\n2015,24.36\r\n2014,24.73", |
References
- Round floating-point scores in test data to a consistent, lower precision. This makes tests more robust against insignificant model output variations and reduces review noise.
| "highlight": { | ||
| "date": "2022", | ||
| "value": 28.369354377079773 | ||
| "value": 28.36935437707979 |
There was a problem hiding this comment.
Round this floating-point value to a lower precision to match the suggested rounding in the dataCsv field and adhere to the general rule regarding test data robustness.
| "value": 28.36935437707979 | |
| "value": 28.37 |
References
- Round floating-point scores in test data to a consistent, lower precision. This makes tests more robust against insignificant model output variations and reduces review noise.
Generated following https://github.com/datacommonsorg/website/tree/master/tools/nl/nodejs_query_differ#update-goldens
Diffs seem due to a data refresh