Add the flags to switch nl search vars from NL Server directly to go through v2 resolve#6179
Conversation
…through v2 resolve
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new feature flag to control the transition of NL search variable resolution to the V2 API. By adding this flag to the existing environment configurations, the team can safely toggle and test the new resolution path without impacting current production behavior. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a new feature flag, use_v2_resolve_for_nl_search_vars, to several environment configuration files including autopush, custom, dev, local, and staging. Feedback suggests that a corresponding constant should be added to the feature flags library to maintain consistency and that the actual implementation logic utilizing this flag appears to be missing from the current changes.
| "name": "use_v2_resolve_for_nl_search_vars", | ||
| "enabled": false, | ||
| "owner": "shixiao", | ||
| "description": "Enables using the V2 resolve API for NL search vars." |
There was a problem hiding this comment.
The new feature flag use_v2_resolve_for_nl_search_vars is added to the configuration files, but it is not defined as a constant in server/lib/feature_flags.py. To maintain consistency and avoid using hardcoded strings when checking the flag in the code, a corresponding constant (e.g., USE_V2_RESOLVE_FOR_NL_SEARCH_VARS) should be added to server/lib/feature_flags.py. Additionally, the implementation logic that utilizes this flag appears to be missing from this pull request, which contradicts the intent described in the PR title and description.
This change add a flag to use v2 resolve for the nl_search_var and then detect-and-fulfill endpoint