Skip to content

Add the flags to switch nl search vars from NL Server directly to go through v2 resolve#6179

Merged
shixiao-coder merged 3 commits intodatacommonsorg:masterfrom
shixiao-coder:feature-flag-for-nl-search-with-v2-resolve
Apr 8, 2026
Merged

Add the flags to switch nl search vars from NL Server directly to go through v2 resolve#6179
shixiao-coder merged 3 commits intodatacommonsorg:masterfrom
shixiao-coder:feature-flag-for-nl-search-with-v2-resolve

Conversation

@shixiao-coder
Copy link
Copy Markdown
Contributor

This change add a flag to use v2 resolve for the nl_search_var and then detect-and-fulfill endpoint

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new feature flag to control the transition of NL search variable resolution to the V2 API. By adding this flag to the existing environment configurations, the team can safely toggle and test the new resolution path without impacting current production behavior.

Highlights

  • Feature Flag Implementation: Added a new feature flag 'use_v2_resolve_for_nl_search_vars' across all environment configurations.
  • Configuration Updates: Updated autopush, custom, dev, local, and staging configuration files to include the new flag, defaulting to disabled.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new feature flag, use_v2_resolve_for_nl_search_vars, to several environment configuration files including autopush, custom, dev, local, and staging. Feedback suggests that a corresponding constant should be added to the feature flags library to maintain consistency and that the actual implementation logic utilizing this flag appears to be missing from the current changes.

Comment on lines +99 to +102
"name": "use_v2_resolve_for_nl_search_vars",
"enabled": false,
"owner": "shixiao",
"description": "Enables using the V2 resolve API for NL search vars."
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new feature flag use_v2_resolve_for_nl_search_vars is added to the configuration files, but it is not defined as a constant in server/lib/feature_flags.py. To maintain consistency and avoid using hardcoded strings when checking the flag in the code, a corresponding constant (e.g., USE_V2_RESOLVE_FOR_NL_SEARCH_VARS) should be added to server/lib/feature_flags.py. Additionally, the implementation logic that utilizes this flag appears to be missing from this pull request, which contradicts the intent described in the PR title and description.

@shixiao-coder shixiao-coder merged commit 863aab9 into datacommonsorg:master Apr 8, 2026
13 checks passed
@shixiao-coder shixiao-coder deleted the feature-flag-for-nl-search-with-v2-resolve branch April 8, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants