Add the production feature flag to switch to v2/resolve for detect-and-fulfill endpoint#6180
Conversation
…d-fulfill endpoint
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new configuration flag in the production environment settings. The purpose of this change is to provide a mechanism to toggle the underlying API implementation for natural language search variable resolution, allowing for a controlled rollout or testing of the V2 resolve endpoint. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new feature flag, use_v2_resolve_for_nl_search_vars, to the production configuration. The reviewer recommends defining a corresponding constant in the Python feature flags library to ensure consistency and prevent potential errors from hardcoded strings.
| "description": "Enables standardized visualization tool UI for the /tool/map, /tool/scatter, and /tool/timeline pages" | ||
| }, | ||
| { | ||
| "name": "use_v2_resolve_for_nl_search_vars", |
There was a problem hiding this comment.
To maintain consistency with the existing feature flag implementation in this repository, please add a corresponding constant in server/lib/feature_flags.py. This practice helps avoid hardcoded strings and potential typos when checking the flag status throughout the codebase.
Suggested constant definition:
USE_V2_RESOLVE_FOR_NL_SEARCH_VARS = 'use_v2_resolve_for_nl_search_vars'
No description provided.