Skip to content

Add the production feature flag to switch to v2/resolve for detect-and-fulfill endpoint#6180

Merged
shixiao-coder merged 4 commits intodatacommonsorg:masterfrom
shixiao-coder:production-feature-flag-for-nl-search-with-v2-resolve
Apr 8, 2026
Merged

Add the production feature flag to switch to v2/resolve for detect-and-fulfill endpoint#6180
shixiao-coder merged 4 commits intodatacommonsorg:masterfrom
shixiao-coder:production-feature-flag-for-nl-search-with-v2-resolve

Conversation

@shixiao-coder
Copy link
Copy Markdown
Contributor

No description provided.

@shixiao-coder shixiao-coder requested a review from juliawu April 6, 2026 21:17
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new configuration flag in the production environment settings. The purpose of this change is to provide a mechanism to toggle the underlying API implementation for natural language search variable resolution, allowing for a controlled rollout or testing of the V2 resolve endpoint.

Highlights

  • Feature Flag Addition: Added a new production feature flag named 'use_v2_resolve_for_nl_search_vars' to control the transition to the V2 resolve API for natural language search variables.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@shixiao-coder shixiao-coder requested a review from gmechali April 6, 2026 21:17
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new feature flag, use_v2_resolve_for_nl_search_vars, to the production configuration. The reviewer recommends defining a corresponding constant in the Python feature flags library to ensure consistency and prevent potential errors from hardcoded strings.

"description": "Enables standardized visualization tool UI for the /tool/map, /tool/scatter, and /tool/timeline pages"
},
{
"name": "use_v2_resolve_for_nl_search_vars",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain consistency with the existing feature flag implementation in this repository, please add a corresponding constant in server/lib/feature_flags.py. This practice helps avoid hardcoded strings and potential typos when checking the flag status throughout the codebase.

Suggested constant definition:
USE_V2_RESOLVE_FOR_NL_SEARCH_VARS = 'use_v2_resolve_for_nl_search_vars'

@shixiao-coder shixiao-coder merged commit 0d067bd into datacommonsorg:master Apr 8, 2026
13 checks passed
@shixiao-coder shixiao-coder deleted the production-feature-flag-for-nl-search-with-v2-resolve branch April 8, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants